* Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable()
@ 2020-05-31 7:01 Markus Elfring
2020-05-31 7:19 ` dinghao.liu
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-05-31 7:01 UTC (permalink / raw)
To: Dinghao Liu, kernel, linux-arm-kernel, linux-i2c, linux-imx
Cc: kernel-janitors, linux-kernel, Dong Aisheng, Fabio Estevam,
Kangjie Lu, Sascha Hauer, Shawn Guo
> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a pairing decrement is needed
> on the error handling path to keep the counter balanced.
* How do you think about to replace the word “pairing” by “corresponding”?
* Will it be helpful to add an imperative wording?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ffeb595d84811dde16a28b33d8a7cf26d51d51b3#n151
* Would you like to add the tag “Fixes” to the commit message?
* Are you going to take such possibilities into account for any more patches?
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable()
2020-05-31 7:01 [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable() Markus Elfring
@ 2020-05-31 7:19 ` dinghao.liu
0 siblings, 0 replies; 2+ messages in thread
From: dinghao.liu @ 2020-05-31 7:19 UTC (permalink / raw)
To: Markus Elfring
Cc: kernel, linux-arm-kernel, linux-i2c, linux-imx, kernel-janitors,
linux-kernel, Dong Aisheng, Fabio Estevam, Kangjie Lu,
Sascha Hauer, Shawn Guo
Hi, Markus,
> * How do you think about to replace the word “pairing” by “corresponding”?
>
> * Will it be helpful to add an imperative wording?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ffeb595d84811dde16a28b33d8a7cf26d51d51b3#n151
>
> * Would you like to add the tag “Fixes” to the commit message?
>
> * Are you going to take such possibilities into account for any more patches?
>
Thank you for your advice! I will fix them soon in the next version of patch.
Regards,
Dinghao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-31 7:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-31 7:01 [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable() Markus Elfring
2020-05-31 7:19 ` dinghao.liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).