* [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource()
@ 2020-09-18 8:25 Wang ShaoBo
2020-09-18 9:20 ` Uwe Kleine-König
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Wang ShaoBo @ 2020-09-18 8:25 UTC (permalink / raw)
Cc: cj.chengjian, huawei.libin, wsa, u.kleine-koenig, linux-i2c,
linux-kernel, linux-arm-kernel
Make use of devm_platform_get_and_ioremap_resource() provided by
driver core platform instead of duplicated analogue. dev_err() is
removed because it has been done in devm_ioremap_resource().
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---
drivers/i2c/busses/i2c-efm32.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
index 838ce0947191..f6e13ceeb2b3 100644
--- a/drivers/i2c/busses/i2c-efm32.c
+++ b/drivers/i2c/busses/i2c-efm32.c
@@ -332,21 +332,15 @@ static int efm32_i2c_probe(struct platform_device *pdev)
return ret;
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(&pdev->dev, "failed to determine base address\n");
- return -ENODEV;
- }
+ ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+ if (IS_ERR(ddata->base))
+ return PTR_ERR(ddata->base);
if (resource_size(res) < 0x42) {
dev_err(&pdev->dev, "memory resource too small\n");
return -EINVAL;
}
- ddata->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(ddata->base))
- return PTR_ERR(ddata->base);
-
ret = platform_get_irq(pdev, 0);
if (ret <= 0) {
if (!ret)
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource()
2020-09-18 8:25 [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource() Wang ShaoBo
@ 2020-09-18 9:20 ` Uwe Kleine-König
2020-09-18 10:01 ` Yicong Yang
2020-09-29 19:38 ` Wolfram Sang
2 siblings, 0 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2020-09-18 9:20 UTC (permalink / raw)
To: Wang ShaoBo
Cc: cj.chengjian, huawei.libin, wsa, linux-i2c, linux-kernel,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
On Fri, Sep 18, 2020 at 04:25:08PM +0800, Wang ShaoBo wrote:
> Make use of devm_platform_get_and_ioremap_resource() provided by
> driver core platform instead of duplicated analogue. dev_err() is
> removed because it has been done in devm_ioremap_resource().
>
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
> drivers/i2c/busses/i2c-efm32.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
> index 838ce0947191..f6e13ceeb2b3 100644
> --- a/drivers/i2c/busses/i2c-efm32.c
> +++ b/drivers/i2c/busses/i2c-efm32.c
> @@ -332,21 +332,15 @@ static int efm32_i2c_probe(struct platform_device *pdev)
> return ret;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "failed to determine base address\n");
> - return -ENODEV;
> - }
> + ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> + if (IS_ERR(ddata->base))
> + return PTR_ERR(ddata->base);
>
> if (resource_size(res) < 0x42) {
> dev_err(&pdev->dev, "memory resource too small\n");
> return -EINVAL;
> }
>
> - ddata->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(ddata->base))
> - return PTR_ERR(ddata->base);
> -
> ret = platform_get_irq(pdev, 0);
> if (ret <= 0) {
> if (!ret)
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource()
2020-09-18 8:25 [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource() Wang ShaoBo
2020-09-18 9:20 ` Uwe Kleine-König
@ 2020-09-18 10:01 ` Yicong Yang
2020-09-18 10:37 ` Wangshaobo (bobo)
2020-09-29 19:38 ` Wolfram Sang
2 siblings, 1 reply; 5+ messages in thread
From: Yicong Yang @ 2020-09-18 10:01 UTC (permalink / raw)
To: Wang ShaoBo
Cc: cj.chengjian, huawei.libin, wsa, u.kleine-koenig, linux-i2c,
linux-kernel, linux-arm-kernel
On 2020/9/18 16:25, Wang ShaoBo wrote:
> Make use of devm_platform_get_and_ioremap_resource() provided by
> driver core platform instead of duplicated analogue. dev_err() is
> removed because it has been done in devm_ioremap_resource().
>
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
> drivers/i2c/busses/i2c-efm32.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
> index 838ce0947191..f6e13ceeb2b3 100644
> --- a/drivers/i2c/busses/i2c-efm32.c
> +++ b/drivers/i2c/busses/i2c-efm32.c
> @@ -332,21 +332,15 @@ static int efm32_i2c_probe(struct platform_device *pdev)
> return ret;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(&pdev->dev, "failed to determine base address\n");
> - return -ENODEV;
> - }
> + ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> + if (IS_ERR(ddata->base))
> + return PTR_ERR(ddata->base);
>
> if (resource_size(res) < 0x42) {
res is not assigned. should it be removed?
> dev_err(&pdev->dev, "memory resource too small\n");
> return -EINVAL;
> }
>
> - ddata->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(ddata->base))
> - return PTR_ERR(ddata->base);
> -
> ret = platform_get_irq(pdev, 0);
> if (ret <= 0) {
> if (!ret)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource()
2020-09-18 10:01 ` Yicong Yang
@ 2020-09-18 10:37 ` Wangshaobo (bobo)
0 siblings, 0 replies; 5+ messages in thread
From: Wangshaobo (bobo) @ 2020-09-18 10:37 UTC (permalink / raw)
To: Yicong Yang
Cc: cj.chengjian, huawei.libin, wsa, u.kleine-koenig, linux-i2c,
linux-kernel, linux-arm-kernel
在 2020/9/18 18:01, Yicong Yang 写道:
> On 2020/9/18 16:25, Wang ShaoBo wrote:
>> Make use of devm_platform_get_and_ioremap_resource() provided by
>> driver core platform instead of duplicated analogue. dev_err() is
>> removed because it has been done in devm_ioremap_resource().
>>
>> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
>> ---
>> drivers/i2c/busses/i2c-efm32.c | 12 +++---------
>> 1 file changed, 3 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
>> index 838ce0947191..f6e13ceeb2b3 100644
>> --- a/drivers/i2c/busses/i2c-efm32.c
>> +++ b/drivers/i2c/busses/i2c-efm32.c
>> @@ -332,21 +332,15 @@ static int efm32_i2c_probe(struct platform_device *pdev)
>> return ret;
>> }
>>
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - dev_err(&pdev->dev, "failed to determine base address\n");
>> - return -ENODEV;
>> - }
>> + ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>> + if (IS_ERR(ddata->base))
>> + return PTR_ERR(ddata->base);
>>
>> if (resource_size(res) < 0x42) {
> res is not assigned. should it be removed?
I am not sure what you want to ask, but devm_platform_get_and_ioremap_resource() will
assign variable res a value, if it is NULL, internal devm_ioremap_resource() will return error
at the begining, so at this time if(IS_ERR(ddata->base)) true and terminate the process,
which is as same as the original sentences work.
>> dev_err(&pdev->dev, "memory resource too small\n");
>> return -EINVAL;
>> }
>>
>> - ddata->base = devm_ioremap_resource(&pdev->dev, res);
>> - if (IS_ERR(ddata->base))
>> - return PTR_ERR(ddata->base);
>> -
>> ret = platform_get_irq(pdev, 0);
>> if (ret <= 0) {
>> if (!ret)
> .
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource()
2020-09-18 8:25 [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource() Wang ShaoBo
2020-09-18 9:20 ` Uwe Kleine-König
2020-09-18 10:01 ` Yicong Yang
@ 2020-09-29 19:38 ` Wolfram Sang
2 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2020-09-29 19:38 UTC (permalink / raw)
To: Wang ShaoBo
Cc: cj.chengjian, huawei.libin, u.kleine-koenig, linux-i2c,
linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
On Fri, Sep 18, 2020 at 04:25:08PM +0800, Wang ShaoBo wrote:
> Make use of devm_platform_get_and_ioremap_resource() provided by
> driver core platform instead of duplicated analogue. dev_err() is
> removed because it has been done in devm_ioremap_resource().
>
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-29 19:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 8:25 [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource() Wang ShaoBo
2020-09-18 9:20 ` Uwe Kleine-König
2020-09-18 10:01 ` Yicong Yang
2020-09-18 10:37 ` Wangshaobo (bobo)
2020-09-29 19:38 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).