From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
To: Ray Jui <ray.jui@broadcom.com>
Cc: Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Wolfram Sang <wsa@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Brendan Higgins <brendanhiggins@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Lori Hikichi <lori.hikichi@broadcom.com>,
Dhananjay Phadke <dphadke@linux.microsoft.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function
Date: Mon, 26 Oct 2020 19:22:27 +0530 [thread overview]
Message-ID: <CAHO=5PF-6Bgo+qmxQDFYYfauK3BuFe7z+AyRn7mDuz-x_XbL=A@mail.gmail.com> (raw)
In-Reply-To: <6232a47d-9ff1-9c4a-6ed1-80b4c6222cc0@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
On Fri, Oct 23, 2020 at 10:51 PM Ray Jui <ray.jui@broadcom.com> wrote:
>
>
>
> On 10/11/2020 11:22 AM, Rayagonda Kokatanur wrote:
> > Fix typo in bcm_iproc_i2c_slave_isr().
> >
> > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")
>
> This is merely a fix of typo in code comment and there's no functional
> impact. Why do we need a Fixes tag on this (which indicates the fix
> needs to be backported to LTS kernels)?
Thank you Ray.
I will remove Fixes tag and push patch v2.
Best regards,
Rayagonda
>
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > ---
> > drivers/i2c/busses/i2c-bcm-iproc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
> > index cd687696bf0b..7a235f9f5884 100644
> > --- a/drivers/i2c/busses/i2c-bcm-iproc.c
> > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c
> > @@ -382,7 +382,7 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c,
> > if (status & BIT(IS_S_START_BUSY_SHIFT)) {
> > i2c_slave_event(iproc_i2c->slave, I2C_SLAVE_STOP, &value);
> > /*
> > - * Enable interrupt for TX FIFO becomes empty and
> > + * Disable interrupt for TX FIFO becomes empty and
> > * less than PKT_LENGTH bytes were output on the SMBUS
> > */
> > val = iproc_i2c_rd_reg(iproc_i2c, IE_OFFSET);
> >
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4187 bytes --]
next prev parent reply other threads:[~2020-10-26 13:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 18:22 [PATCH v1 0/6] fix iproc driver to handle master read request Rayagonda Kokatanur
2020-10-11 18:22 ` [PATCH v1 1/6] i2c: iproc: handle Master aborted error Rayagonda Kokatanur
2020-10-23 17:14 ` Ray Jui
2020-10-11 18:22 ` [PATCH v1 2/6] i2c: iproc: handle only slave interrupts which are enabled Rayagonda Kokatanur
2020-10-23 17:18 ` Ray Jui
2020-10-11 18:22 ` [PATCH v1 3/6] i2c: iproc: update slave isr mask (ISR_MASK_SLAVE) Rayagonda Kokatanur
2020-10-23 17:19 ` Ray Jui
2020-10-11 18:22 ` [PATCH v1 4/6] i2c: iproc: fix typo in slave_isr function Rayagonda Kokatanur
2020-10-23 17:20 ` Ray Jui
2020-10-26 13:52 ` Rayagonda Kokatanur [this message]
2020-10-11 18:22 ` [PATCH v1 5/6] i2c: iproc: handle master read request Rayagonda Kokatanur
2020-10-14 3:20 ` Dhananjay Phadke
2020-10-14 9:12 ` Rayagonda Kokatanur
[not found] ` <CAHO=5PEtoJrFEPin0hH19Ubs9Zmhxiay4jSGAhXBFE=ft=+CYg@mail.gmail.com>
2020-10-23 17:26 ` Ray Jui
2020-10-26 13:55 ` Rayagonda Kokatanur
2020-10-11 18:22 ` [PATCH v1 6/6] i2c: iproc: handle rx fifo full interrupt Rayagonda Kokatanur
2020-10-12 22:03 ` Dhananjay Phadke
2020-10-23 17:42 ` Ray Jui
2020-10-26 15:13 ` Rayagonda Kokatanur
2020-10-27 0:36 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHO=5PF-6Bgo+qmxQDFYYfauK3BuFe7z+AyRn7mDuz-x_XbL=A@mail.gmail.com' \
--to=rayagonda.kokatanur@broadcom.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brendanhiggins@google.com \
--cc=dphadke@linux.microsoft.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lori.hikichi@broadcom.com \
--cc=ray.jui@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).