From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
"Chris Brandt" <Chris.Brandt@renesas.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
"Jean Delvare" <jdelvare@suse.de>,
"Khalil Blaiech" <kblaiech@mellanox.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Bence Csókás" <bence98@sch.bme.hu>,
"Yicong Yang" <yangyicong@hisilicon.com>,
"Mike Rapoport" <rppt@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linux I2C" <linux-i2c@vger.kernel.org>,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Biju Das" <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH 3/5] i2c: riic: Add RZ/G2L support
Date: Mon, 14 Jun 2021 16:04:55 +0000 [thread overview]
Message-ID: <OS0PR01MB5922831680086DECF7F7920386319@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWWgehDTxTcm8=ooq2-4BkY0jgo+hwfrM_PHc6iw6aP8A@mail.gmail.com>
Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> Subject: Re: [PATCH 3/5] i2c: riic: Add RZ/G2L support
>
> Hi Biju,
>
> On Fri, Jun 11, 2021 at 6:56 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > RZ/G2L i2c controller is compatible with RZ/A i2c controller.
> > By default IP is in reset state, so need to perform release reset
> > before accessing any register.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -941,6 +941,7 @@ config I2C_QUP
> > config I2C_RIIC
> > tristate "Renesas RIIC adapter"
> > depends on ARCH_RENESAS || COMPILE_TEST
> > + select RESET_CONTROLLER
>
> if ARCH_R9A07G044?
OK,Agreed.
>
> > --- a/drivers/i2c/busses/i2c-riic.c
> > +++ b/drivers/i2c/busses/i2c-riic.c
> _kzalloc(&pdev->dev, sizeof(*riic), GFP_KERNEL);
> > if (!riic)
> > @@ -412,6 +421,17 @@ static int riic_i2c_probe(struct platform_device
> *pdev)
> > return PTR_ERR(riic->clk);
> > }
> >
> > + type = (enum riic_type)of_device_get_match_data(&pdev->dev);
> > + if (type == RIIC_RZ_G2L) {
> > + rstc = devm_reset_control_get(&pdev->dev, NULL);
> > + if (IS_ERR(rstc)) {
> > + dev_err(&pdev->dev, "Error: missing reset
> ctrl\n");
> > + return PTR_ERR(rstc);
> > + }
> > +
> > + reset_control_deassert(rstc);
>
> Just wondering: does it harm if the driver is unloaded or unbounded, and
> rebound while the I2C controller is not in reset state?
I have tested and it works after unloading and reloading it again.
Cheers,
Biju
>
> > + }
> > +
> > for (i = 0; i < ARRAY_SIZE(riic_irqs); i++) {
> > res = platform_get_resource(pdev, IORESOURCE_IRQ,
> riic_irqs[i].res_num);
> > if (!res)
> > @@ -472,6 +492,7 @@ static int riic_i2c_remove(struct platform_device
> > *pdev) }
> >
> > static const struct of_device_id riic_i2c_dt_ids[] = {
> > + { .compatible = "renesas,riic-r9a07g044", .data = (void
> > + *)RIIC_RZ_G2L },
> > { .compatible = "renesas,riic-rz" },
>
> Please fill in .data, to avoid relying implicitly on RIIC_RZ_A being zero.
>
> > { /* Sentinel */ },
> > };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2021-06-14 16:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 16:56 [PATCH 0/5] Add RZ/G2L I2C support Biju Das
2021-06-11 16:56 ` [PATCH 1/5] dt-bindings: i2c: renesas,riic: Document RZ/G2L I2C controller Biju Das
2021-06-14 12:43 ` Geert Uytterhoeven
2021-06-11 16:56 ` [PATCH 3/5] i2c: riic: Add RZ/G2L support Biju Das
2021-06-14 12:38 ` Geert Uytterhoeven
2021-06-14 16:04 ` Biju Das [this message]
2021-06-14 13:27 ` Philipp Zabel
2021-06-14 13:38 ` Geert Uytterhoeven
2021-06-14 17:20 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922831680086DECF7F7920386319@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Brandt@renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=arnd@arndb.de \
--cc=bence98@sch.bme.hu \
--cc=biju.das@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=kblaiech@mellanox.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rppt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).