From: Wolfram Sang <wsa@the-dreams.de>
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: linux-i2c@vger.kernel.org, Scott Wood <oss@buserror.net>
Subject: Re: [PATCHv2] i2c-mpc: Correct I2C reset procedure
Date: Mon, 29 Nov 2021 12:51:21 +0100 [thread overview]
Message-ID: <YaS+ueLqCADpvBHP@kunai> (raw)
In-Reply-To: <20170511122033.22471-1-joakim.tjernlund@infinera.com>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
On Thu, May 11, 2017 at 02:20:33PM +0200, Joakim Tjernlund wrote:
> Current I2C reset procedure is broken in two ways:
> 1) It only generate 1 START instead of 9 STARTs and STOP.
> 2) It leaves the bus Busy so every I2C xfer after the first
> fixup calls the reset routine again, for every xfer there after.
>
> This fixes both errors.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Acked-by: Scott Wood <oss@buserror.net>
Okay, I admit it is strange to apply a patch after 4 years, but I am
doing a bus_recovery overhaul right now and Joakim mentioned a few
times, he is still using this patch.
I still do wonder why the generic bus recovery algorithm can't be used.
It has been updated quite a bit and at least sends STOPs after each
pulse (as a result of an earlier discussion about this patch). But a
conversion to generic bus recovery wasn't happening, so apply a) what
users need and b) document what worked for them. Maybe the conversion
will happen somewhen and/or the algorithm here might improve the generic
one. We will see.
That all being said:
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-11-29 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 12:20 [PATCHv2] i2c-mpc: Correct I2C reset procedure Joakim Tjernlund
2017-05-16 15:13 ` Joakim Tjernlund
2017-05-23 13:47 ` Joakim Tjernlund
2017-05-24 0:58 ` Scott Wood
2017-05-29 21:04 ` Wolfram Sang
2017-05-29 22:03 ` Joakim Tjernlund
2017-06-21 21:36 ` Wolfram Sang
2017-06-21 21:59 ` Wolfram Sang
2017-06-22 8:40 ` Joakim Tjernlund
2017-06-22 10:00 ` Wolfram Sang
2017-06-22 11:39 ` Joakim Tjernlund
2017-06-18 16:27 ` Joakim Tjernlund
2021-11-29 11:51 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaS+ueLqCADpvBHP@kunai \
--to=wsa@the-dreams.de \
--cc=joakim.tjernlund@infinera.com \
--cc=linux-i2c@vger.kernel.org \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).