* Re: [PATCH] i2c: cadence: Add error handling for a platform_get_irq() call in cdns_i2c_probe()
@ 2020-05-20 11:52 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-20 11:52 UTC (permalink / raw)
To: Dejin Zheng, linux-i2c; +Cc: linux-kernel, Michal Simek, Wolfram Sang
> The driver initialization should be end immediately after found
> the platform_get_irq() function return an error.
I suggest to improve also this change description.
How do you think about a wording variant like the following?
Return an error code after a call of the function “platform_get_irq” failed.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-20 11:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-20 11:52 [PATCH] i2c: cadence: Add error handling for a platform_get_irq() call in cdns_i2c_probe() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).