* [PATCH] i3c: Correct the macro module_i3c_i2c_driver
@ 2022-12-05 10:54 Naveen Krishna Chatradhi
2022-12-11 20:22 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Naveen Krishna Chatradhi @ 2022-12-05 10:54 UTC (permalink / raw)
To: linux-i3c, alexandre.belloni
Cc: linux-kernel, boris.brezillon, Naveen Krishna Chatradhi, Akshay Gupta
From: Naveen Krishna Chatradhi <nchatrad@amd.com>
Present definition for module_i3c_i2c_driver uses only the
1st argument i.e., struct i3c_driver.
Irrespective of CONFIG_I3C being enabled/disabled,
struct i2c_driver is never passed to module_driver()
Passing struct i2c_driver as the 4th argument works.
Signed-off-by: Akshay Gupta <Akshay.Gupta@amd.com>
Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
---
include/linux/i3c/device.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
index 8242e13e7b0b..419192b5cc4d 100644
--- a/include/linux/i3c/device.h
+++ b/include/linux/i3c/device.h
@@ -287,7 +287,8 @@ static inline void i3c_i2c_driver_unregister(struct i3c_driver *i3cdrv,
#define module_i3c_i2c_driver(__i3cdrv, __i2cdrv) \
module_driver(__i3cdrv, \
i3c_i2c_driver_register, \
- i3c_i2c_driver_unregister)
+ i3c_i2c_driver_unregister, \
+ __i2cdrv)
int i3c_device_do_priv_xfers(struct i3c_device *dev,
struct i3c_priv_xfer *xfers,
--
2.25.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i3c: Correct the macro module_i3c_i2c_driver
2022-12-05 10:54 [PATCH] i3c: Correct the macro module_i3c_i2c_driver Naveen Krishna Chatradhi
@ 2022-12-11 20:22 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2022-12-11 20:22 UTC (permalink / raw)
To: linux-i3c, Naveen Krishna Chatradhi
Cc: Akshay Gupta, boris.brezillon, linux-kernel, Naveen Krishna Chatradhi
On Mon, 5 Dec 2022 10:54:13 +0000, Naveen Krishna Chatradhi wrote:
> From: Naveen Krishna Chatradhi <nchatrad@amd.com>
>
> Present definition for module_i3c_i2c_driver uses only the
> 1st argument i.e., struct i3c_driver.
> Irrespective of CONFIG_I3C being enabled/disabled,
> struct i2c_driver is never passed to module_driver()
>
> [...]
Applied, thanks!
[1/1] i3c: Correct the macro module_i3c_i2c_driver
commit: 01744ce9f07f0b76b0b2d30adba2a7c104f1ff2a
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-11 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 10:54 [PATCH] i3c: Correct the macro module_i3c_i2c_driver Naveen Krishna Chatradhi
2022-12-11 20:22 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).