Linux-i3c Archive on lore.kernel.org
 help / color / Atom feed
From: Vitor Soares <Vitor.Soares@synopsys.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
	Vitor Soares <Vitor.Soares@synopsys.com>
Cc: Przemyslaw Gaj <pgaj@cadence.com>,
	"agolec@cadence.com" <agolec@cadence.com>,
	"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
	"rafalc@cadence.com" <rafalc@cadence.com>,
	"bbrezillon@kernel.org" <bbrezillon@kernel.org>
Subject: RE: [PATCH v5 4/7] i3c: Add support for mastership request to I3C subsystem
Date: Thu, 22 Aug 2019 11:08:41 +0000
Message-ID: <SN6PR12MB26551AEDEC830BE3A75859F3AEA50@SN6PR12MB2655.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190812165531.28a38c78@collabora.com>

Hi Boris,

From: Boris Brezillon <boris.brezillon@collabora.com>
Date: Mon, Aug 12, 2019 at 15:55:31

> > > > > > > > 
> > > > > > > > It is not clear to me what you expect with these functions. Do you want 
> > > > > > > > to enable MR from all devices? Just some of them? How do you decide which 
> > > > > > > > secondary masters are allow earn the bus ownership?
> > > > > > > >     
> > > > > > > 
> > > > > > > We discussed this also. For now, we enable ENEC for all masters on the bus, we
> > > > > > > can change it later if needed.     
> > > > > > 
> > > > > > I would say to expand the current ibi framework to accommodate MR and    
> > > > > 
> > > > > Can you tell something more here? What benefits you see    
> > > > 
> > > > Just starting with the name. IBI stands for In Band Interrupt which can 
> > > > be MR, HJ or SIR.
> > > > 
> > > > Also the concept is the same, let say you are registering a SIR w/out 
> > > > data but in fact it is a MR.  
> > > 
> > > No, it's not from a SW PoV. IBI are events I3C device drivers can
> > > register a handler for, MR and HJ events are things the HC drivers are
> > > expected to handle, and that's a big difference. While re-using the IBI
> > > API to handle them should be doable I don't think it will make things
> > > simpler.
> > >   
> > 
> > In that case we need to rename the functions with slave interrupt request 
> > (SIR) in mind.
> 
> I'm fine changing ibi for sir. Can you send a patch doing that?
> 

I address this topic on MIPI forum and it is correct to assume IBI as SIR 
and not MR.
With this clarification is not necessary to change the 
functions/structures/variables names.

Best regards,
Vitor Soares

_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-22 20:54 [PATCH v5 0/7] Add the I3C mastership request Przemyslaw Gaj
2019-06-22 20:54 ` [PATCH v5 1/7] i3c: add addr and lvr to i2c_dev_desc structure Przemyslaw Gaj
2019-06-22 20:55 ` [PATCH v5 2/7] i3c: split i3c_master_register into init - register pair Przemyslaw Gaj
2019-07-06  8:48   ` Boris Brezillon
2019-06-22 20:55 ` [PATCH v5 3/7] i3c: export i3c_bus_set_mode function Przemyslaw Gaj
2019-07-06  7:39   ` Boris Brezillon
2019-06-22 20:55 ` [PATCH v5 4/7] i3c: Add support for mastership request to I3C subsystem Przemyslaw Gaj
2019-07-06  9:00   ` Boris Brezillon
2019-07-10 18:04   ` Vitor Soares
2019-07-11  5:28     ` Przemyslaw Gaj
2019-07-11 10:11       ` Vitor Soares
2019-07-12 10:10         ` Przemyslaw Gaj
2019-07-12 11:28           ` Vitor Soares
2019-08-11 10:17             ` Boris Brezillon
2019-08-12 13:55               ` Vitor Soares
2019-08-12 14:55                 ` Boris Brezillon
2019-08-22 11:08                   ` Vitor Soares [this message]
2019-06-22 20:55 ` [PATCH v5 5/7] i3c: master: cdns: add support for mastership request to Cadence I3C master driver Przemyslaw Gaj
2019-06-22 20:55 ` [PATCH v5 6/7] i3c: master: Add module author Przemyslaw Gaj
2019-06-22 20:55 ` [PATCH v5 7/7] MAINTAINERS: add myself as co-maintainer of i3c subsystem Przemyslaw Gaj

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR12MB26551AEDEC830BE3A75859F3AEA50@SN6PR12MB2655.namprd12.prod.outlook.com \
    --to=vitor.soares@synopsys.com \
    --cc=agolec@cadence.com \
    --cc=bbrezillon@kernel.org \
    --cc=boris.brezillon@collabora.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=pgaj@cadence.com \
    --cc=rafalc@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-i3c Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-i3c/0 linux-i3c/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-i3c linux-i3c/ https://lore.kernel.org/linux-i3c \
		linux-i3c@lists.infradead.org linux-i3c@archiver.kernel.org
	public-inbox-index linux-i3c


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-i3c


AGPL code for this site: git clone https://public-inbox.org/ public-inbox