From: vitor <vitor.soares@synopsys.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
vitor <vitor.soares@synopsys.com>
Cc: linux-i3c@lists.infradead.org, joao.pinto@synopsys.com,
bbrezillon@kernel.org
Subject: Re: [PATCH] i3c: master:dw: Fix dw_i3c_master_disable controller by using correct mask
Date: Mon, 1 Apr 2019 17:58:26 +0100 [thread overview]
Message-ID: <c6c02957-b3e6-b7d4-f590-848676455139@synopsys.com> (raw)
In-Reply-To: <20190330085452.47ec2621@collabora.com>
Hi Boris,
Thanks for your feedback.
On 30/03/19 07:54, Boris Brezillon wrote:
> On Wed, 27 Mar 2019 21:37:59 +0000
> vitor <vitor.soares@synopsys.com> wrote:
>
>> Hi Boris,
>>
>>
>> On 06/03/19 21:57, Vitor Soares wrote:
>>> The controller is disable by clear the DEV_CTRL_ENABLE bit rather
> ^disabled by clearing
>
>>> than set it. This is fixed by using the correct mask.
> ^setting
>
>
> The commit message is not accurate. You were not setting the
> DEV_CTRL_ENABLE bit, you were actually masking all other bits and
> keeping the DEV_CTRL_ENABLE one unchanged.
>
>>> Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
> Missing
>
> Cc: <stable@vger.kernel.org>
>
> line.
>
> Can you send a new version with this fixed?
>
> Thanks,
>
> Boris
>
Sure.
Best regards,
Vitor Soares
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2019-04-01 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 21:57 [PATCH] i3c: master:dw: Fix dw_i3c_master_disable controller by using correct mask Vitor Soares
2019-03-27 21:37 ` vitor
2019-03-30 7:54 ` Boris Brezillon
2019-04-01 16:58 ` vitor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6c02957-b3e6-b7d4-f590-848676455139@synopsys.com \
--to=vitor.soares@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=joao.pinto@synopsys.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).