From: vitor <vitor.soares@synopsys.com>
To: Vitor Soares <vitor.soares@synopsys.com>, <bbrezillon@kernel.org>
Cc: linux-i3c@lists.infradead.org, joao.pinto@synopsys.com
Subject: Re: [PATCH] i3c: master:dw: Fix dw_i3c_master_disable controller by using correct mask
Date: Wed, 27 Mar 2019 21:37:59 +0000 [thread overview]
Message-ID: <e02e8ce4-e392-99db-b1c1-d9b5046033d4@synopsys.com> (raw)
In-Reply-To: <9af6e8d204c7d846b727a9a010b79f1df7ecec1e.1551907779.git.vitor.soares@synopsys.com>
Hi Boris,
On 06/03/19 21:57, Vitor Soares wrote:
> The controller is disable by clear the DEV_CTRL_ENABLE bit rather
> than set it. This is fixed by using the correct mask.
>
> Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> ---
> drivers/i3c/master/dw-i3c-master.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index bb03079..ec385fb 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -300,7 +300,7 @@ to_dw_i3c_master(struct i3c_master_controller *master)
>
> static void dw_i3c_master_disable(struct dw_i3c_master *master)
> {
> - writel(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_ENABLE,
> + writel(readl(master->regs + DEVICE_CTRL) & ~DEV_CTRL_ENABLE,
> master->regs + DEVICE_CTRL);
> }
>
Friendly ping.
Best regards,
Vitor Soares
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-03-27 21:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 21:57 [PATCH] i3c: master:dw: Fix dw_i3c_master_disable controller by using correct mask Vitor Soares
2019-03-27 21:37 ` vitor [this message]
2019-03-30 7:54 ` Boris Brezillon
2019-04-01 16:58 ` vitor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02e8ce4-e392-99db-b1c1-d9b5046033d4@synopsys.com \
--to=vitor.soares@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=joao.pinto@synopsys.com \
--cc=linux-i3c@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).