* [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel()
@ 2019-12-17 7:40 ` Peter Ujfalusi
2020-01-13 11:22 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2019-12-17 7:40 UTC (permalink / raw)
To: b.zolnierkie, axboe; +Cc: vkoul, linux-ide, linux-kernel
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.
By using dma_request_chan() directly the driver can support deferred
probing against DMA.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/ata/pata_pxa.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
index 41430f79663c..71678bed04b0 100644
--- a/drivers/ata/pata_pxa.c
+++ b/drivers/ata/pata_pxa.c
@@ -274,10 +274,9 @@ static int pxa_ata_probe(struct platform_device *pdev)
/*
* Request the DMA channel
*/
- data->dma_chan =
- dma_request_slave_channel(&pdev->dev, "data");
- if (!data->dma_chan)
- return -EBUSY;
+ data->dma_chan = dma_request_chan(&pdev->dev, "data");
+ if (IS_ERR(data->dma_chan))
+ return PTR_ERR(data->dma_chan);
ret = dmaengine_slave_config(data->dma_chan, &config);
if (ret < 0) {
dev_err(&pdev->dev, "dma configuration failed: %d\n", ret);
--
Peter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel()
2019-12-17 7:40 ` [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
@ 2020-01-13 11:22 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2020-01-13 11:22 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: axboe, vkoul, linux-ide, linux-kernel
On 12/17/19 8:40 AM, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/ata/pata_pxa.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
> index 41430f79663c..71678bed04b0 100644
> --- a/drivers/ata/pata_pxa.c
> +++ b/drivers/ata/pata_pxa.c
> @@ -274,10 +274,9 @@ static int pxa_ata_probe(struct platform_device *pdev)
> /*
> * Request the DMA channel
> */
> - data->dma_chan =
> - dma_request_slave_channel(&pdev->dev, "data");
> - if (!data->dma_chan)
> - return -EBUSY;
> + data->dma_chan = dma_request_chan(&pdev->dev, "data");
> + if (IS_ERR(data->dma_chan))
> + return PTR_ERR(data->dma_chan);
> ret = dmaengine_slave_config(data->dma_chan, &config);
> if (ret < 0) {
> dev_err(&pdev->dev, "dma configuration failed: %d\n", ret);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-13 11:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20191217074028eucas1p1eeef714e4d8c2cff2c133ffd239d7468@eucas1p1.samsung.com>
2019-12-17 7:40 ` [PATCH] ata: pxa: Use dma_request_chan() instead dma_request_slave_channel() Peter Ujfalusi
2020-01-13 11:22 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).