* [PATCH] ata: return true in ata_is_host_link() @ 2020-05-07 11:06 ` Jason Yan 2020-06-01 13:33 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Jason Yan @ 2020-05-07 11:06 UTC (permalink / raw) To: axboe, b.zolnierkie, linux-ide, linux-kernel; +Cc: Jason Yan Fix the following coccicheck warning: include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function 'ata_is_host_link' with return type bool Signed-off-by: Jason Yan <yanaijie@huawei.com> --- include/linux/libata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/libata.h b/include/linux/libata.h index 8bf5e59a7859..e05a8ed2e31e 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -1443,7 +1443,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap) static inline bool ata_is_host_link(const struct ata_link *link) { - return 1; + return true; } #endif /* CONFIG_SATA_PMP */ -- 2.21.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: return true in ata_is_host_link() 2020-05-07 11:06 ` [PATCH] ata: return true in ata_is_host_link() Jason Yan @ 2020-06-01 13:33 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2020-06-01 13:33 UTC (permalink / raw) To: Jason Yan; +Cc: axboe, linux-ide, linux-kernel On 5/7/20 1:06 PM, Jason Yan wrote: > Fix the following coccicheck warning: > > include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function > 'ata_is_host_link' with return type bool > > Signed-off-by: Jason Yan <yanaijie@huawei.com> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > include/linux/libata.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/libata.h b/include/linux/libata.h > index 8bf5e59a7859..e05a8ed2e31e 100644 > --- a/include/linux/libata.h > +++ b/include/linux/libata.h > @@ -1443,7 +1443,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap) > > static inline bool ata_is_host_link(const struct ata_link *link) > { > - return 1; > + return true; > } > #endif /* CONFIG_SATA_PMP */ > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-01 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200507110752eucas1p21e8a1d127642c53440fe64c4a770e3f7@eucas1p2.samsung.com>
2020-05-07 11:06 ` [PATCH] ata: return true in ata_is_host_link() Jason Yan
2020-06-01 13:33 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).