linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Mark Lord <mlord@pobox.com>,
	ALWAYS copy <linux-ide@vger.kernel.org>
Subject: [PATCH 18/20] ata: sata_mv: Fix worthy headers and demote others
Date: Thu, 28 Jan 2021 18:02:37 +0000	[thread overview]
Message-ID: <20210128180239.548512-19-lee.jones@linaro.org> (raw)
In-Reply-To: <20210128180239.548512-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma'
 drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma'
 drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'protocol' not described in 'mv_start_edma'
 drivers/ata/sata_mv.c:1162: warning: Excess function parameter 'base' description in 'mv_start_edma'
 drivers/ata/sata_mv.c:1535: warning: Function parameter or member 'enable_bmdma' not described in 'mv_bmdma_enable_iie'
 drivers/ata/sata_mv.c:1535: warning: expecting prototype for mv_bmdma_enable(). Prototype was for mv_bmdma_enable_iie() instead
 drivers/ata/sata_mv.c:1930: warning: Function parameter or member 'ap' not described in 'mv_bmdma_stop_ap'
 drivers/ata/sata_mv.c:1930: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead
 drivers/ata/sata_mv.c:2228: warning: Function parameter or member 'ap' not described in 'mv_send_fis'
 drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'hpriv' not described in 'mv6_reset_hc'
 drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'n_hc' not described in 'mv6_reset_hc'
 drivers/ata/sata_mv.c:3541: warning: Function parameter or member 'hpriv' not described in 'soc_is_65n'
 drivers/ata/sata_mv.c:3541: warning: expecting prototype for soc_is_65(). Prototype was for soc_is_65n() instead

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Mark Lord <mlord@pobox.com>
Cc: ALWAYS copy <linux-ide@vger.kernel.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ata/sata_mv.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 664ef658a955f..eafca46d8feb4 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -1146,9 +1146,8 @@ static void mv_set_irq_coalescing(struct ata_host *host,
 	spin_unlock_irqrestore(&host->lock, flags);
 }
 
-/**
+/*
  *      mv_start_edma - Enable eDMA engine
- *      @base: port base address
  *      @pp: port private data
  *
  *      Verify the local cache of the eDMA state is accurate with a
@@ -1519,7 +1518,7 @@ static void mv_60x1_errata_sata25(struct ata_port *ap, int want_ncq)
 		writel(new, hpriv->base + GPIO_PORT_CTL);
 }
 
-/**
+/*
  *	mv_bmdma_enable - set a magic bit on GEN_IIE to allow bmdma
  *	@ap: Port being initialized
  *
@@ -1919,7 +1918,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc)
 
 /**
  *	mv_bmdma_stop - Stop BMDMA transfer
- *	@qc: queued command to stop DMA on.
+ *	@ap: port to stop
  *
  *	Clears the ATA_DMA_START flag in the bmdma control register
  *
@@ -2221,6 +2220,7 @@ static u8 mv_sff_check_status(struct ata_port *ap)
 
 /**
  *	mv_send_fis - Send a FIS, using the "Vendor-Unique FIS" register
+ *	@ap: ATA port to send a FIS
  *	@fis: fis to be sent
  *	@nwords: number of 32-bit words in the fis
  */
@@ -3249,7 +3249,7 @@ static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio)
 	writel(tmp, mmio + GPIO_PORT_CTL);
 }
 
-/**
+/*
  *      mv6_reset_hc - Perform the 6xxx global soft reset
  *      @mmio: base address of the HBA
  *
@@ -3530,7 +3530,7 @@ static void mv_soc_65n_phy_errata(struct mv_host_priv *hpriv,
 	writel(reg, port_mmio + PHY_MODE9_GEN1);
 }
 
-/**
+/*
  *	soc_is_65 - check if the soc is 65 nano device
  *
  *	Detect the type of the SoC, this is done by reading the PHYCFG_OFS
-- 
2.25.1


  parent reply	other threads:[~2021-01-28 18:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
2021-01-28 18:02 ` [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init Lee Jones
2021-01-28 18:19   ` Christoph Hellwig
2021-01-28 18:27     ` Lee Jones
2021-02-01 11:05       ` Arnd Bergmann
2021-02-01 13:56         ` Lee Jones
2021-01-28 18:02 ` [PATCH 02/20] ata: libata-transport: Fix some potential doc-rot issues Lee Jones
2021-01-28 18:02 ` [PATCH 03/20] ata: ahci_platform: Ignore -Woverride-init Lee Jones
2021-01-28 18:02 ` [PATCH 04/20] ata: libata-sata: Fix function names in header comments Lee Jones
2021-01-28 18:02 ` [PATCH 05/20] ata: libata-pmp: Fix misspelling of 'val' Lee Jones
2021-01-28 18:02 ` [PATCH 06/20] ata: ahci_mtk: Ignore -Woverride-init Lee Jones
2021-01-28 18:02 ` [PATCH 07/20] ata: pata_ali: Repair some misnamed kernel-doc issues Lee Jones
2021-01-28 18:02 ` [PATCH 08/20] ata: pata_artop: Fix a function name and parameter description Lee Jones
2021-01-28 18:02 ` [PATCH 09/20] ata: acard-ahci: Ignore -Woverride-init Lee Jones
2021-01-28 18:02 ` [PATCH 10/20] ata: ahci_ceva: " Lee Jones
2021-01-28 18:02 ` [PATCH 11/20] ata: pata_amd: Remove superfluous, add missing and fix broken params Lee Jones
2021-01-28 18:02 ` [PATCH 12/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param Lee Jones
2021-01-28 18:02 ` [PATCH 13/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues Lee Jones
2021-01-28 18:02 ` [PATCH 14/20] ata: sata_sil24: Ignore -Woverride-init Lee Jones
2021-01-28 18:02 ` [PATCH 15/20] ata: sata_highbank: " Lee Jones
2021-01-28 18:02 ` [PATCH 16/20] ata: ahci_brcm: " Lee Jones
2021-01-28 18:02 ` [PATCH 17/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param Lee Jones
2021-01-28 18:02 ` Lee Jones [this message]
2021-01-28 18:02 ` [PATCH 19/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param Lee Jones
2021-01-28 18:02 ` [PATCH 20/20] ata: ahci: Ignore -Woverride-init Lee Jones
2021-01-29  5:53 ` [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128180239.548512-19-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlord@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).