* [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:19 ` Christoph Hellwig
2021-01-28 18:02 ` [PATCH 02/20] ata: libata-transport: Fix some potential doc-rot issues Lee Jones
` (19 subsequent siblings)
20 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/ahci_dm816.c:16:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_dm816_platform_sht.can_queue’)
drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_dm816_platform_sht.sdev_attrs’)
drivers/ata/ahci_dm816.c:138:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index b8aebfb14e825..d24bf4d2b08d6 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,5 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
+CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
+
obj-$(CONFIG_ATA) += libata.o
# non-SFF interface
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init
2021-01-28 18:02 ` [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init Lee Jones
@ 2021-01-28 18:19 ` Christoph Hellwig
2021-01-28 18:27 ` Lee Jones
0 siblings, 1 reply; 26+ messages in thread
From: Christoph Hellwig @ 2021-01-28 18:19 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, Jens Axboe, linux-ide
On Thu, Jan 28, 2021 at 06:02:20PM +0000, Lee Jones wrote:
> Some ATA drivers use the SCSI host template, a series of interwoven
> macros, to aid with initialisation. Some of these macros conflict,
> resulting in the over-writing of previously set values.
Please just disable this warning globally. This is a sensible
patter and we should not sprinkle per-file options for something
that fundamental.
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init
2021-01-28 18:19 ` Christoph Hellwig
@ 2021-01-28 18:27 ` Lee Jones
2021-02-01 11:05 ` Arnd Bergmann
0 siblings, 1 reply; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:27 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-kernel, Jens Axboe, linux-ide
On Thu, 28 Jan 2021, Christoph Hellwig wrote:
> On Thu, Jan 28, 2021 at 06:02:20PM +0000, Lee Jones wrote:
> > Some ATA drivers use the SCSI host template, a series of interwoven
> > macros, to aid with initialisation. Some of these macros conflict,
> > resulting in the over-writing of previously set values.
>
> Please just disable this warning globally. This is a sensible
> patter and we should not sprinkle per-file options for something
> that fundamental.
Will do. Just as soon as I've figured out how. :)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init
2021-01-28 18:27 ` Lee Jones
@ 2021-02-01 11:05 ` Arnd Bergmann
2021-02-01 13:56 ` Lee Jones
0 siblings, 1 reply; 26+ messages in thread
From: Arnd Bergmann @ 2021-02-01 11:05 UTC (permalink / raw)
To: Lee Jones; +Cc: Christoph Hellwig, linux-kernel, Jens Axboe, IDE-ML
On Thu, Jan 28, 2021 at 7:32 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Thu, 28 Jan 2021, Christoph Hellwig wrote:
>
> > On Thu, Jan 28, 2021 at 06:02:20PM +0000, Lee Jones wrote:
> > > Some ATA drivers use the SCSI host template, a series of interwoven
> > > macros, to aid with initialisation. Some of these macros conflict,
> > > resulting in the over-writing of previously set values.
> >
> > Please just disable this warning globally. This is a sensible
> > patter and we should not sprinkle per-file options for something
> > that fundamental.
>
> Will do. Just as soon as I've figured out how. :)
I have a local patch series doing it like this
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 5f550eb27f81..4e4cc14a289e 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1390,6 +1390,8 @@ extern struct device_attribute *ata_common_sdev_attrs[];
* edge driver's module reference, otherwise the driver can be unloaded
* even if the scsi_device is being accessed.
*/
+__diag_ignore(GCC, 8, "-Woverride-init", "intentional override")
+__diag_ignore(CLANG, 9, "-Winitializer-overrides", "intentional override")
#define __ATA_BASE_SHT(drv_name) \
.module = THIS_MODULE, \
.name = drv_name, \
I think this also requires a preparation patch to extend __diag_ignore to
additional compiler versions, not sure if that was already merged.
Arnd
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init
2021-02-01 11:05 ` Arnd Bergmann
@ 2021-02-01 13:56 ` Lee Jones
0 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-02-01 13:56 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Christoph Hellwig, linux-kernel, Jens Axboe, IDE-ML
On Mon, 01 Feb 2021, Arnd Bergmann wrote:
> On Thu, Jan 28, 2021 at 7:32 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Thu, 28 Jan 2021, Christoph Hellwig wrote:
> >
> > > On Thu, Jan 28, 2021 at 06:02:20PM +0000, Lee Jones wrote:
> > > > Some ATA drivers use the SCSI host template, a series of interwoven
> > > > macros, to aid with initialisation. Some of these macros conflict,
> > > > resulting in the over-writing of previously set values.
> > >
> > > Please just disable this warning globally. This is a sensible
> > > patter and we should not sprinkle per-file options for something
> > > that fundamental.
> >
> > Will do. Just as soon as I've figured out how. :)
>
> I have a local patch series doing it like this
Can I leave this in your capable hands then?
I'll drop all my fixes for this if it can be replaced with just one.
> diff --git a/include/linux/libata.h b/include/linux/libata.h
> index 5f550eb27f81..4e4cc14a289e 100644
> --- a/include/linux/libata.h
> +++ b/include/linux/libata.h
> @@ -1390,6 +1390,8 @@ extern struct device_attribute *ata_common_sdev_attrs[];
> * edge driver's module reference, otherwise the driver can be unloaded
> * even if the scsi_device is being accessed.
> */
> +__diag_ignore(GCC, 8, "-Woverride-init", "intentional override")
> +__diag_ignore(CLANG, 9, "-Winitializer-overrides", "intentional override")
> #define __ATA_BASE_SHT(drv_name) \
> .module = THIS_MODULE, \
> .name = drv_name, \
>
> I think this also requires a preparation patch to extend __diag_ignore to
> additional compiler versions, not sure if that was already merged.
>
> Arnd
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 26+ messages in thread
* [PATCH 02/20] ata: libata-transport: Fix some potential doc-rot issues
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
2021-01-28 18:02 ` [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 03/20] ata: ahci_platform: Ignore -Woverride-init Lee Jones
` (18 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/libata-transport.c:258: warning: Function parameter or member 'ap' not described in 'ata_tport_delete'
drivers/ata/libata-transport.c:258: warning: Excess function parameter 'port' description in 'ata_tport_delete'
drivers/ata/libata-transport.c:384: warning: Function parameter or member 'link' not described in 'ata_tlink_delete'
drivers/ata/libata-transport.c:384: warning: Excess function parameter 'port' description in 'ata_tlink_delete'
drivers/ata/libata-transport.c:640: warning: Function parameter or member 'ata_dev' not described in 'ata_tdev_delete'
drivers/ata/libata-transport.c:640: warning: Excess function parameter 'port' description in 'ata_tdev_delete'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/libata-transport.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c
index 6a40e3c6cf492..34bb4608bdc67 100644
--- a/drivers/ata/libata-transport.c
+++ b/drivers/ata/libata-transport.c
@@ -250,7 +250,7 @@ static int ata_tport_match(struct attribute_container *cont,
/**
* ata_tport_delete -- remove ATA PORT
- * @port: ATA PORT to remove
+ * @ap: ATA PORT to remove
*
* Removes the specified ATA PORT. Remove the associated link as well.
*/
@@ -376,7 +376,7 @@ static int ata_tlink_match(struct attribute_container *cont,
/**
* ata_tlink_delete -- remove ATA LINK
- * @port: ATA LINK to remove
+ * @link: ATA LINK to remove
*
* Removes the specified ATA LINK. remove associated ATA device(s) as well.
*/
@@ -632,7 +632,7 @@ static void ata_tdev_free(struct ata_device *dev)
/**
* ata_tdev_delete -- remove ATA device
- * @port: ATA PORT to remove
+ * @ata_dev: ATA device to remove
*
* Removes the specified ATA device.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 03/20] ata: ahci_platform: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
2021-01-28 18:02 ` [PATCH 01/20] ata: ahci_dm816: Ignore -Woverride-init Lee Jones
2021-01-28 18:02 ` [PATCH 02/20] ata: libata-transport: Fix some potential doc-rot issues Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 04/20] ata: libata-sata: Fix function names in header comments Lee Jones
` (17 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/ahci_platform.c:21:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’)
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_platform.c:40:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index d24bf4d2b08d6..c7c26a0ef7632 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
+CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init)
obj-$(CONFIG_ATA) += libata.o
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 04/20] ata: libata-sata: Fix function names in header comments
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (2 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 03/20] ata: ahci_platform: Ignore -Woverride-init Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 05/20] ata: libata-pmp: Fix misspelling of 'val' Lee Jones
` (16 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, Tejun Heo, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/libata-sata.c:1085: warning: expecting prototype for port_alloc(). Prototype was for ata_sas_port_alloc() instead
drivers/ata/libata-sata.c:1140: warning: expecting prototype for ata_port_stop(). Prototype was for ata_sas_port_stop() instead
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/libata-sata.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-sata.c b/drivers/ata/libata-sata.c
index c16423e445255..8adeab76dd382 100644
--- a/drivers/ata/libata-sata.c
+++ b/drivers/ata/libata-sata.c
@@ -1067,7 +1067,7 @@ int ata_scsi_change_queue_depth(struct scsi_device *sdev, int queue_depth)
EXPORT_SYMBOL_GPL(ata_scsi_change_queue_depth);
/**
- * port_alloc - Allocate port for a SAS attached SATA device
+ * ata_sas_port_alloc - Allocate port for a SAS attached SATA device
* @host: ATA host container for all SAS ports
* @port_info: Information from low-level host driver
* @shost: SCSI host that the scsi device is attached to
@@ -1127,7 +1127,7 @@ int ata_sas_port_start(struct ata_port *ap)
EXPORT_SYMBOL_GPL(ata_sas_port_start);
/**
- * ata_port_stop - Undo ata_sas_port_start()
+ * ata_sas_port_stop - Undo ata_sas_port_start()
* @ap: Port to shut down
*
* May be used as the port_stop() entry in ata_port_operations.
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 05/20] ata: libata-pmp: Fix misspelling of 'val'
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (3 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 04/20] ata: libata-sata: Fix function names in header comments Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 06/20] ata: ahci_mtk: Ignore -Woverride-init Lee Jones
` (15 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, Tejun Heo, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write'
drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <teheo@suse.de>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/libata-pmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c
index 79f2aeeb482ab..ba7be3f386171 100644
--- a/drivers/ata/libata-pmp.c
+++ b/drivers/ata/libata-pmp.c
@@ -62,7 +62,7 @@ static unsigned int sata_pmp_read(struct ata_link *link, int reg, u32 *r_val)
* sata_pmp_write - write PMP register
* @link: link to write PMP register for
* @reg: register to write
- * @r_val: value to write
+ * @val: value to write
*
* Write PMP register.
*
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 06/20] ata: ahci_mtk: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (4 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 05/20] ata: libata-pmp: Fix misspelling of 'val' Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 07/20] ata: pata_ali: Repair some misnamed kernel-doc issues Lee Jones
` (14 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/ahci_mtk.c:18:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’)
drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_mtk.c:41:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index c7c26a0ef7632..79c59550c23a0 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
+CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init)
obj-$(CONFIG_ATA) += libata.o
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 07/20] ata: pata_ali: Repair some misnamed kernel-doc issues
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (5 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 06/20] ata: ahci_mtk: Ignore -Woverride-init Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 08/20] ata: pata_artop: Fix a function name and parameter description Lee Jones
` (13 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jens Axboe, CJ, Andre Hedrick, Alan Cox,
Clear Zhang, linux-ide, and cc
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter'
drivers/ata/pata_ali.c:119: warning: Excess function parameter 'ap' description in 'ali_20_filter'
drivers/ata/pata_ali.c:322: warning: Function parameter or member 'qc' not described in 'ali_check_atapi_dma'
drivers/ata/pata_ali.c:322: warning: Excess function parameter 'adev' description in 'ali_check_atapi_dma'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: CJ <cjtsai@ali.com.tw>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Alan Cox <alan@redhat.com>
Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
Cc: linux-ide@vger.kernel.org
Cc: and cc <htejun@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/pata_ali.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index 0b122f903b8a8..e18aa02f89530 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -108,7 +108,7 @@ static int ali_c2_cable_detect(struct ata_port *ap)
/**
* ali_20_filter - filter for earlier ALI DMA
- * @ap: ALi ATA port
+ * @adev: ATA device
* @adev: attached device
*
* Ensure that we do not do DMA on CD devices. We may be able to
@@ -313,7 +313,7 @@ static void ali_lock_sectors(struct ata_device *adev)
/**
* ali_check_atapi_dma - DMA check for most ALi controllers
- * @adev: Device
+ * @qc: Command to complete
*
* Called to decide whether commands should be sent by DMA or PIO
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 08/20] ata: pata_artop: Fix a function name and parameter description
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (6 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 07/20] ata: pata_ali: Repair some misnamed kernel-doc issues Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 09/20] ata: acard-ahci: Ignore -Woverride-init Lee Jones
` (12 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jens Axboe, Andre Hedrick, Thibaut VARENE,
Alessandro Zummo, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_artop.c:278: warning: expecting prototype for artop_6210_qc_defer(). Prototype was for artop6210_qc_defer() instead
drivers/ata/pata_artop.c:359: warning: Function parameter or member 'id' not described in 'artop_init_one'
drivers/ata/pata_artop.c:359: warning: Excess function parameter 'ent' description in 'artop_init_one'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Thibaut VARENE <varenet@parisc-linux.org>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/pata_artop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_artop.c b/drivers/ata/pata_artop.c
index 6bd2228bb6ffa..02e4fd5e3b934 100644
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -344,7 +344,7 @@ static void atp8xx_fixup(struct pci_dev *pdev)
/**
* artop_init_one - Register ARTOP ATA PCI device with kernel services
* @pdev: PCI device to register
- * @ent: Entry in artop_pci_tbl matching with @pdev
+ * @id: PCI device ID
*
* Called from kernel PCI layer.
*
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 09/20] ata: acard-ahci: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (7 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 08/20] ata: pata_artop: Fix a function name and parameter description Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 10/20] ata: ahci_ceva: " Lee Jones
` (11 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/acard-ahci.c:33:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘acard_ahci_sht.can_queue’)
drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘acard_ahci_sht.sdev_attrs’)
drivers/ata/acard-ahci.c:70:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 79c59550c23a0..4542f101042ac 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,5 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
+CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init)
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 10/20] ata: ahci_ceva: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (8 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 09/20] ata: acard-ahci: Ignore -Woverride-init Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 11/20] ata: pata_amd: Remove superfluous, add missing and fix broken params Lee Jones
` (10 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/ahci_ceva.c:15:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’)
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_ceva.c:187:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/sata_sil24.c:378:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/sata_sil24.c:378:16: note: (near initialization for ‘sil24_sht.can_queue’)
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 4542f101042ac..c7460c6b94c1d 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init)
+CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init)
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 11/20] ata: pata_amd: Remove superfluous, add missing and fix broken params
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (9 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 10/20] ata: ahci_ceva: " Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 12/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param Lee Jones
` (9 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_amd.c:179: warning: Excess function parameter 'adev' description in 'amd_fifo_setup'
drivers/ata/pata_amd.c:331: warning: Function parameter or member 'link' not described in 'nv_pre_reset'
drivers/ata/pata_amd.c:331: warning: Function parameter or member 'deadline' not described in 'nv_pre_reset'
drivers/ata/pata_amd.c:331: warning: expecting prototype for nv_probe_init(). Prototype was for nv_pre_reset() instead
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/pata_amd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c
index 987967f976cb2..75b830eb3c542 100644
--- a/drivers/ata/pata_amd.c
+++ b/drivers/ata/pata_amd.c
@@ -167,7 +167,6 @@ static int amd_cable_detect(struct ata_port *ap)
/**
* amd_fifo_setup - set the PIO FIFO for ATA/ATAPI
* @ap: ATA interface
- * @adev: ATA device
*
* Set the PCI fifo for this device according to the devices present
* on the bus at this point in time. We need to turn the post write buffer
@@ -321,7 +320,8 @@ static unsigned long nv_mode_filter(struct ata_device *dev,
/**
* nv_probe_init - cable detection
- * @lin: ATA link
+ * @link: ATA link
+ * @deadline: deadline jiffies for the operation
*
* Perform cable detection. The BIOS stores this in PCI config
* space for us.
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 12/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (10 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 11/20] ata: pata_amd: Remove superfluous, add missing and fix broken params Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 13/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues Lee Jones
` (8 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, Andre Hedrick, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_hpt366.c:200: warning: Function parameter or member 'mask' not described in 'hpt366_filter'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/pata_hpt366.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c
index 2574d6fbb1ad3..06b7c4a9ec954 100644
--- a/drivers/ata/pata_hpt366.c
+++ b/drivers/ata/pata_hpt366.c
@@ -192,6 +192,7 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr,
/**
* hpt366_filter - mode selection filter
* @adev: ATA device
+ * @mask: Current mask to manipulate and pass back
*
* Block UDMA on devices that cause trouble with this controller.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 13/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (11 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 12/20] ata: pata_hpt366: Provide missing description for 'hpt366_filter()'s 'mask' param Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 14/20] ata: sata_sil24: Ignore -Woverride-init Lee Jones
` (7 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, Andre Hedrick, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_hpt37x.c:283: warning: Function parameter or member 'mask' not described in 'hpt370_filter'
drivers/ata/pata_hpt37x.c:301: warning: Function parameter or member 'mask' not described in 'hpt370a_filter'
drivers/ata/pata_hpt37x.c:473: warning: expecting prototype for hpt370_bmdma_end(). Prototype was for hpt370_bmdma_stop() instead
drivers/ata/pata_hpt37x.c:567: warning: expecting prototype for hpt37x_bmdma_end(). Prototype was for hpt37x_bmdma_stop() instead
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/pata_hpt37x.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
index fad6c6a873130..f242157bc81bb 100644
--- a/drivers/ata/pata_hpt37x.c
+++ b/drivers/ata/pata_hpt37x.c
@@ -275,6 +275,7 @@ static const char * const bad_ata100_5[] = {
/**
* hpt370_filter - mode selection filter
* @adev: ATA device
+ * @mask: mode mask
*
* Block UDMA on devices that cause trouble with this controller.
*/
@@ -293,6 +294,7 @@ static unsigned long hpt370_filter(struct ata_device *adev, unsigned long mask)
/**
* hpt370a_filter - mode selection filter
* @adev: ATA device
+ * @mask: mode mask
*
* Block UDMA on devices that cause trouble with this controller.
*/
@@ -463,7 +465,7 @@ static void hpt370_set_dmamode(struct ata_port *ap, struct ata_device *adev)
}
/**
- * hpt370_bmdma_end - DMA engine stop
+ * hpt370_bmdma_stop - DMA engine stop
* @qc: ATA command
*
* Work around the HPT370 DMA engine.
@@ -557,7 +559,7 @@ static void hpt372_set_dmamode(struct ata_port *ap, struct ata_device *adev)
}
/**
- * hpt37x_bmdma_end - DMA engine stop
+ * hpt37x_bmdma_stop - DMA engine stop
* @qc: ATA command
*
* Clean up after the HPT372 and later DMA engine
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 14/20] ata: sata_sil24: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (12 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 13/20] ata: pata_hpt37x: Fix some function misnaming and missing param issues Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 15/20] ata: sata_highbank: " Lee Jones
` (6 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/sata_sil24.c:14:
drivers/ata/sata_sil24.c:381:22: note: in expansion of macro ‘BLK_TAG_ALLOC_FIFO’
drivers/ata/sata_sil24.c:381:22: note: in expansion of macro ‘BLK_TAG_ALLOC_FIFO’
drivers/ata/libata-pmp.c:76: warning: Function parameter or member 'val' not described in 'sata_pmp_write'
drivers/ata/libata-pmp.c:76: warning: Excess function parameter 'r_val' description in 'sata_pmp_write'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index c7460c6b94c1d..d46703777cdd4 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -5,6 +5,7 @@ CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init)
+CFLAGS_sata_sil24.o = $(call cc-disable-warning, override-init)
obj-$(CONFIG_ATA) += libata.o
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 15/20] ata: sata_highbank: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (13 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 14/20] ata: sata_sil24: Ignore -Woverride-init Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 16/20] ata: ahci_brcm: " Lee Jones
` (5 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/sata_highbank.c:25:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_highbank_platform_sht.can_queue’)
drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_highbank_platform_sht.sdev_attrs’)
drivers/ata/sata_highbank.c:442:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index d46703777cdd4..cf851f5a4e7fd 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -5,6 +5,7 @@ CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_platform.o = $(call cc-disable-warning, override-init)
+CFLAGS_sata_highbank.o = $(call cc-disable-warning, override-init)
CFLAGS_sata_sil24.o = $(call cc-disable-warning, override-init)
obj-$(CONFIG_ATA) += libata.o
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 16/20] ata: ahci_brcm: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (14 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 15/20] ata: sata_highbank: " Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 17/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param Lee Jones
` (4 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/ahci_brcm.c:22:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_platform_sht.can_queue’)
drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_platform_sht.sdev_attrs’)
drivers/ata/ahci_brcm.c:414:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index cf851f5a4e7fd..a6755a524efa0 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init)
+CFLAGS_ahci_brcm.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_mtk.o = $(call cc-disable-warning, override-init)
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 17/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (15 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 16/20] ata: ahci_brcm: " Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 18/20] ata: sata_mv: Fix worthy headers and demote others Lee Jones
` (3 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jens Axboe, Loc Ho, Tuan Phan, Suman Tripathi, linux-ide
Fixes the following W=1 kernel build warning(s):
drivers/ata/ahci_xgene.c:564: warning: Function parameter or member 'host' not described in 'xgene_ahci_handle_broken_edge_irq'
drivers/ata/ahci_xgene.c:564: warning: Excess function parameter 'ata_host' description in 'xgene_ahci_handle_broken_edge_irq'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Loc Ho <lho@apm.com>
Cc: Tuan Phan <tphan@apm.com>
Cc: Suman Tripathi <stripathi@apm.com>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/ahci_xgene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 16246c843365e..dffc432b9d54a 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -537,7 +537,7 @@ static int xgene_ahci_softreset(struct ata_link *link, unsigned int *class,
/**
* xgene_ahci_handle_broken_edge_irq - Handle the broken irq.
- * @ata_host: Host that recieved the irq
+ * @host: Host that recieved the irq
* @irq_masked: HOST_IRQ_STAT value
*
* For hardware with broken edge trigger latch
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 18/20] ata: sata_mv: Fix worthy headers and demote others
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (16 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 17/20] ata: ahci_xgene: Fix incorrect naming of 'xgene_ahci_handle_broken_edge_irq()'s 'host' param Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 19/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param Lee Jones
` (2 subsequent siblings)
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, Mark Lord, ALWAYS copy
Fixes the following W=1 kernel build warning(s):
drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'ap' not described in 'mv_start_edma'
drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'port_mmio' not described in 'mv_start_edma'
drivers/ata/sata_mv.c:1162: warning: Function parameter or member 'protocol' not described in 'mv_start_edma'
drivers/ata/sata_mv.c:1162: warning: Excess function parameter 'base' description in 'mv_start_edma'
drivers/ata/sata_mv.c:1535: warning: Function parameter or member 'enable_bmdma' not described in 'mv_bmdma_enable_iie'
drivers/ata/sata_mv.c:1535: warning: expecting prototype for mv_bmdma_enable(). Prototype was for mv_bmdma_enable_iie() instead
drivers/ata/sata_mv.c:1930: warning: Function parameter or member 'ap' not described in 'mv_bmdma_stop_ap'
drivers/ata/sata_mv.c:1930: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead
drivers/ata/sata_mv.c:2228: warning: Function parameter or member 'ap' not described in 'mv_send_fis'
drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'hpriv' not described in 'mv6_reset_hc'
drivers/ata/sata_mv.c:3263: warning: Function parameter or member 'n_hc' not described in 'mv6_reset_hc'
drivers/ata/sata_mv.c:3541: warning: Function parameter or member 'hpriv' not described in 'soc_is_65n'
drivers/ata/sata_mv.c:3541: warning: expecting prototype for soc_is_65(). Prototype was for soc_is_65n() instead
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Mark Lord <mlord@pobox.com>
Cc: ALWAYS copy <linux-ide@vger.kernel.org>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/sata_mv.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 664ef658a955f..eafca46d8feb4 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -1146,9 +1146,8 @@ static void mv_set_irq_coalescing(struct ata_host *host,
spin_unlock_irqrestore(&host->lock, flags);
}
-/**
+/*
* mv_start_edma - Enable eDMA engine
- * @base: port base address
* @pp: port private data
*
* Verify the local cache of the eDMA state is accurate with a
@@ -1519,7 +1518,7 @@ static void mv_60x1_errata_sata25(struct ata_port *ap, int want_ncq)
writel(new, hpriv->base + GPIO_PORT_CTL);
}
-/**
+/*
* mv_bmdma_enable - set a magic bit on GEN_IIE to allow bmdma
* @ap: Port being initialized
*
@@ -1919,7 +1918,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc)
/**
* mv_bmdma_stop - Stop BMDMA transfer
- * @qc: queued command to stop DMA on.
+ * @ap: port to stop
*
* Clears the ATA_DMA_START flag in the bmdma control register
*
@@ -2221,6 +2220,7 @@ static u8 mv_sff_check_status(struct ata_port *ap)
/**
* mv_send_fis - Send a FIS, using the "Vendor-Unique FIS" register
+ * @ap: ATA port to send a FIS
* @fis: fis to be sent
* @nwords: number of 32-bit words in the fis
*/
@@ -3249,7 +3249,7 @@ static void mv6_reset_flash(struct mv_host_priv *hpriv, void __iomem *mmio)
writel(tmp, mmio + GPIO_PORT_CTL);
}
-/**
+/*
* mv6_reset_hc - Perform the 6xxx global soft reset
* @mmio: base address of the HBA
*
@@ -3530,7 +3530,7 @@ static void mv_soc_65n_phy_errata(struct mv_host_priv *hpriv,
writel(reg, port_mmio + PHY_MODE9_GEN1);
}
-/**
+/*
* soc_is_65 - check if the soc is 65 nano device
*
* Detect the type of the SoC, this is done by reading the PHYCFG_OFS
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 19/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (17 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 18/20] ata: sata_mv: Fix worthy headers and demote others Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-28 18:02 ` [PATCH 20/20] ata: ahci: Ignore -Woverride-init Lee Jones
2021-01-29 5:53 ` [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Christoph Hellwig
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jens Axboe, CJ, Andre Hedrick, Alan Cox,
Clear Zhang, linux-ide, and cc
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_ali.c:119: warning: Function parameter or member 'mask' not described in 'ali_20_filter'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: CJ <cjtsai@ali.com.tw>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Alan Cox <alan@redhat.com>
Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
Cc: linux-ide@vger.kernel.org
Cc: and cc <htejun@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/pata_ali.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index e18aa02f89530..557ecf4661022 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -109,7 +109,7 @@ static int ali_c2_cable_detect(struct ata_port *ap)
/**
* ali_20_filter - filter for earlier ALI DMA
* @adev: ATA device
- * @adev: attached device
+ * @mask: received mask to manipulate and pass back
*
* Ensure that we do not do DMA on CD devices. We may be able to
* fix that later on. Also ensure we do not do UDMA on WDC drives
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* [PATCH 20/20] ata: ahci: Ignore -Woverride-init
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (18 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 19/20] ata: pata_ali: Supply description for 'ali_20_filter()'s 'mask' param Lee Jones
@ 2021-01-28 18:02 ` Lee Jones
2021-01-29 5:53 ` [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Christoph Hellwig
20 siblings, 0 replies; 26+ messages in thread
From: Lee Jones @ 2021-01-28 18:02 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jens Axboe, linux-ide
Some ATA drivers use the SCSI host template, a series of interwoven
macros, to aid with initialisation. Some of these macros conflict,
resulting in the over-writing of previously set values.
This is known behaviour and can be safely ignored.
Fixes the following W=1 kernel build warning(s):
In file included from drivers/ata/ahci.c:35:
drivers/ata/ahci.h:387:16: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:387:16: note: (near initialization for ‘ahci_sht.can_queue’)
drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: warning: initialized field overwritten [-Woverride-init]
drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’
drivers/ata/ahci.h:391:17: note: (near initialization for ‘ahci_sht.sdev_attrs’)
drivers/ata/ahci.c:104:2: note: in expansion of macro ‘AHCI_SHT’
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/ata/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index a6755a524efa0..4580a0306bf3d 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
CFLAGS_acard-ahci.o = $(call cc-disable-warning, override-init)
+CFLAGS_ahci.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_brcm.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_ceva.o = $(call cc-disable-warning, override-init)
CFLAGS_ahci_dm816.o = $(call cc-disable-warning, override-init)
--
2.25.1
^ permalink raw reply related [flat|nested] 26+ messages in thread* Re: [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA
2021-01-28 18:02 [PATCH 00/20] [Set 1] Rid W=1 warnings from ATA Lee Jones
` (19 preceding siblings ...)
2021-01-28 18:02 ` [PATCH 20/20] ata: ahci: Ignore -Woverride-init Lee Jones
@ 2021-01-29 5:53 ` Christoph Hellwig
20 siblings, 0 replies; 26+ messages in thread
From: Christoph Hellwig @ 2021-01-29 5:53 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alan Cox, Alessandro Zummo, ALWAYS copy, and cc,
Andre Hedrick, CJ, Clear Zhang, Jens Axboe, Loc Ho, Mark Lord,
Suman Tripathi, Tejun Heo, Thibaut VARENE, Tuan Phan
Everything except the individual CFLAGS flags looks fine to me,
so for all the patches except for the CFLAGS changes:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 26+ messages in thread