* [PATCH] ata: pata_ali: no need to initialise statics to 0
@ 2021-11-13 6:26 Jason Wang
2021-11-29 11:37 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Jason Wang @ 2021-11-13 6:26 UTC (permalink / raw)
To: damien.lemoal; +Cc: linux-ide, linux-kernel, Jason Wang
Static variables do not need to be initialized to 0.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/ata/pata_ali.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
index b7ff63ed3bbb..ab28a6707b94 100644
--- a/drivers/ata/pata_ali.c
+++ b/drivers/ata/pata_ali.c
@@ -37,7 +37,7 @@
#define DRV_NAME "pata_ali"
#define DRV_VERSION "0.7.8"
-static int ali_atapi_dma = 0;
+static int ali_atapi_dma;
module_param_named(atapi_dma, ali_atapi_dma, int, 0644);
MODULE_PARM_DESC(atapi_dma, "Enable ATAPI DMA (0=disable, 1=enable)");
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: pata_ali: no need to initialise statics to 0
2021-11-13 6:26 [PATCH] ata: pata_ali: no need to initialise statics to 0 Jason Wang
@ 2021-11-29 11:37 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2021-11-29 11:37 UTC (permalink / raw)
To: Jason Wang; +Cc: linux-ide
On 2021/11/13 15:26, Jason Wang wrote:
> Static variables do not need to be initialized to 0.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/ata/pata_ali.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_ali.c b/drivers/ata/pata_ali.c
> index b7ff63ed3bbb..ab28a6707b94 100644
> --- a/drivers/ata/pata_ali.c
> +++ b/drivers/ata/pata_ali.c
> @@ -37,7 +37,7 @@
> #define DRV_NAME "pata_ali"
> #define DRV_VERSION "0.7.8"
>
> -static int ali_atapi_dma = 0;
> +static int ali_atapi_dma;
> module_param_named(atapi_dma, ali_atapi_dma, int, 0644);
> MODULE_PARM_DESC(atapi_dma, "Enable ATAPI DMA (0=disable, 1=enable)");
Applied to for-5.17. Thanks.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-29 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-13 6:26 [PATCH] ata: pata_ali: no need to initialise statics to 0 Jason Wang
2021-11-29 11:37 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).