* [GIT PULL] libata fixes for 5.16-rc2
@ 2021-11-19 22:13 Damien Le Moal
2021-11-19 22:21 ` pr-tracker-bot
0 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2021-11-19 22:13 UTC (permalink / raw)
To: Linus Torvalds, linux-ide
Linus,
The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:
Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)
are available in the Git repository at:
ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/libata-5.16-rc2
for you to fetch changes up to cac7e8b5f5fa94e28d581fbb9e76cb1c0c7fd56a:
ata: libata-sata: Declare ata_ncq_sdev_attrs static (2021-11-18 14:34:25 +0900)
----------------------------------------------------------------
libata fixes for 5.16-rc2
* Prevent accesses to unsupported log pages as that causes device scan
failures with LLDDs using libsas (from me).
* A couple of fixes for AMD AHCI adapters handling of low power modes
and resume (from Mario).
* Fix a compilation warning (from me).
----------------------------------------------------------------
Damien Le Moal (3):
ata: libata: improve ata_read_log_page() error message
ata: libata: add missing ata_identify_page_supported() calls
ata: libata-sata: Declare ata_ncq_sdev_attrs static
Mario Limonciello (2):
ata: ahci: Add Green Sardine vendor ID as board_ahci_mobile
ata: libahci: Adjust behavior when StorageD3Enable _DSD is set
drivers/ata/ahci.c | 1 +
drivers/ata/libahci.c | 15 +++++++++++++++
drivers/ata/libata-core.c | 11 ++++++++---
drivers/ata/libata-sata.c | 2 +-
4 files changed, 25 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] libata fixes for 5.16-rc2
2021-11-19 22:13 [GIT PULL] libata fixes for 5.16-rc2 Damien Le Moal
@ 2021-11-19 22:21 ` pr-tracker-bot
0 siblings, 0 replies; 8+ messages in thread
From: pr-tracker-bot @ 2021-11-19 22:21 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Linus Torvalds, linux-ide
The pull request you sent on Sat, 20 Nov 2021 07:13:49 +0900:
> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/libata-5.16-rc2
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a90af8f15bdc9449ee2d24e1d73fa3f7e8633f81
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] libata fixes for 5.16-rc2
2021-11-19 19:06 ` Linus Torvalds
2021-11-19 21:06 ` Sergei Shtylyov
@ 2021-11-19 22:02 ` Damien Le Moal
1 sibling, 0 replies; 8+ messages in thread
From: Damien Le Moal @ 2021-11-19 22:02 UTC (permalink / raw)
To: Linus Torvalds, Sergei Shtylyov; +Cc: linux-ide
On 11/20/21 04:06, Linus Torvalds wrote:
> On Fri, Nov 19, 2021 at 7:46 AM Sergei Shtylyov
> <sergei.shtylyov@gmail.com> wrote:
>> On 19.11.2021 11:49, Damien Le Moal wrote:
>>> Baokun Li (2):
>>> sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
>>> sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
>>
>> At least this one needs fixing! You were too fast at merging... :-/
>> Well, I guess this will need a follow-up fix now...
>
> Hmm. I'm missing the context, but considering this note I have skipped
> this libata pull request.
>
> Damien?
My apologies about that. I am going to update the PR and resend. The
read log patches need to go in. Without them, some drives fail to be
detected at boot time with some HBAs.
>
> Linus
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] libata fixes for 5.16-rc2
2021-11-19 15:46 ` Sergei Shtylyov
2021-11-19 19:06 ` Linus Torvalds
@ 2021-11-19 22:01 ` Damien Le Moal
1 sibling, 0 replies; 8+ messages in thread
From: Damien Le Moal @ 2021-11-19 22:01 UTC (permalink / raw)
To: Sergei Shtylyov, Linus Torvalds, linux-ide
On 11/20/21 00:46, Sergei Shtylyov wrote:
> Hello!
>
> On 19.11.2021 11:49, Damien Le Moal wrote:
>
>> Linus,
>>
>> The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:
>>
>> Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)
>>
>> are available in the Git repository at:
>>
>> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/libata-5.16-rc2
>>
>> for you to fetch changes up to 6873c30c1b797997f302fe1707bee9a7f247dfe2:
>>
>> sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl (2021-11-19 13:57:18 +0900)
>>
>> ----------------------------------------------------------------
>> libata fixes for 5.16-rc2
>>
>> * Prevent accesses to unsupported log pages as that causes device scan
>> failures with LLDDs using libsas (from me).
>> * A couple of fixes for AMD AHCI adapters handling of low power modes
>> and resume (from Mario).
>> * Fix a compilation warning (from me).
>> * Fix sata_fsl driver problems on PPC64 (from Baokun).
>>
>> ----------------------------------------------------------------
>>
>> Baokun Li (2):
>> sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
>> sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
>
> At least this one needs fixing! You were too fast at merging... :-/
Arg... And I did read about that function to check before applying the
patch. But I missed the error check. I am going to drop these patches
for now. They can go into rc3 after fixing.
> Well, I guess this will need a follow-up fix now...
I will request a V2 to the author so that it gets tested (I do not have
that hardware, so I cannot test myself).
>
> [...]
>
> MBR, Sergey
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] libata fixes for 5.16-rc2
2021-11-19 19:06 ` Linus Torvalds
@ 2021-11-19 21:06 ` Sergei Shtylyov
2021-11-19 22:02 ` Damien Le Moal
1 sibling, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2021-11-19 21:06 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Damien Le Moal, linux-ide
On 19.11.2021 22:06, Linus Torvalds wrote:
>> On 19.11.2021 11:49, Damien Le Moal wrote:
>>> Baokun Li (2):
>>> sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
>>> sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
>>
>> At least this one needs fixing! You were too fast at merging... :-/
>> Well, I guess this will need a follow-up fix now...
>
> Hmm. I'm missing the context, but considering this note I have skipped
> this libata pull request.
The patch replaced irq_of_parse_and_map() with platform_get_irq() but
didn't update the error check from (!irq) to (irq < 0)... Quite frequent
mistake in the past; it actually helps if you look at the function itself
before starting to use it. :-)
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] libata fixes for 5.16-rc2
2021-11-19 15:46 ` Sergei Shtylyov
@ 2021-11-19 19:06 ` Linus Torvalds
2021-11-19 21:06 ` Sergei Shtylyov
2021-11-19 22:02 ` Damien Le Moal
2021-11-19 22:01 ` Damien Le Moal
1 sibling, 2 replies; 8+ messages in thread
From: Linus Torvalds @ 2021-11-19 19:06 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Damien Le Moal, linux-ide
On Fri, Nov 19, 2021 at 7:46 AM Sergei Shtylyov
<sergei.shtylyov@gmail.com> wrote:
> On 19.11.2021 11:49, Damien Le Moal wrote:
> > Baokun Li (2):
> > sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
> > sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
>
> At least this one needs fixing! You were too fast at merging... :-/
> Well, I guess this will need a follow-up fix now...
Hmm. I'm missing the context, but considering this note I have skipped
this libata pull request.
Damien?
Linus
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [GIT PULL] libata fixes for 5.16-rc2
2021-11-19 8:49 Damien Le Moal
@ 2021-11-19 15:46 ` Sergei Shtylyov
2021-11-19 19:06 ` Linus Torvalds
2021-11-19 22:01 ` Damien Le Moal
0 siblings, 2 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2021-11-19 15:46 UTC (permalink / raw)
To: Damien Le Moal, Linus Torvalds, linux-ide
Hello!
On 19.11.2021 11:49, Damien Le Moal wrote:
> Linus,
>
> The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:
>
> Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)
>
> are available in the Git repository at:
>
> ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/libata-5.16-rc2
>
> for you to fetch changes up to 6873c30c1b797997f302fe1707bee9a7f247dfe2:
>
> sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl (2021-11-19 13:57:18 +0900)
>
> ----------------------------------------------------------------
> libata fixes for 5.16-rc2
>
> * Prevent accesses to unsupported log pages as that causes device scan
> failures with LLDDs using libsas (from me).
> * A couple of fixes for AMD AHCI adapters handling of low power modes
> and resume (from Mario).
> * Fix a compilation warning (from me).
> * Fix sata_fsl driver problems on PPC64 (from Baokun).
>
> ----------------------------------------------------------------
>
> Baokun Li (2):
> sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
> sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
At least this one needs fixing! You were too fast at merging... :-/
Well, I guess this will need a follow-up fix now...
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 8+ messages in thread
* [GIT PULL] libata fixes for 5.16-rc2
@ 2021-11-19 8:49 Damien Le Moal
2021-11-19 15:46 ` Sergei Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Damien Le Moal @ 2021-11-19 8:49 UTC (permalink / raw)
To: Linus Torvalds, linux-ide
Linus,
The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:
Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)
are available in the Git repository at:
ssh://git@gitolite.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata tags/libata-5.16-rc2
for you to fetch changes up to 6873c30c1b797997f302fe1707bee9a7f247dfe2:
sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl (2021-11-19 13:57:18 +0900)
----------------------------------------------------------------
libata fixes for 5.16-rc2
* Prevent accesses to unsupported log pages as that causes device scan
failures with LLDDs using libsas (from me).
* A couple of fixes for AMD AHCI adapters handling of low power modes
and resume (from Mario).
* Fix a compilation warning (from me).
* Fix sata_fsl driver problems on PPC64 (from Baokun).
----------------------------------------------------------------
Baokun Li (2):
sata_fsl: fix UAF in sata_fsl_port_stop when rmmod sata_fsl
sata_fsl: fix warning in remove_proc_entry when rmmod sata_fsl
Damien Le Moal (3):
ata: libata: improve ata_read_log_page() error message
ata: libata: add missing ata_identify_page_supported() calls
ata: libata-sata: Declare ata_ncq_sdev_attrs static
Mario Limonciello (2):
ata: ahci: Add Green Sardine vendor ID as board_ahci_mobile
ata: libahci: Adjust behavior when StorageD3Enable _DSD is set
drivers/ata/ahci.c | 1 +
drivers/ata/libahci.c | 15 +++++++++++++++
drivers/ata/libata-core.c | 11 ++++++++---
drivers/ata/libata-sata.c | 2 +-
drivers/ata/sata_fsl.c | 21 +++++++++++++++------
5 files changed, 40 insertions(+), 10 deletions(-)
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-19 22:21 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-19 22:13 [GIT PULL] libata fixes for 5.16-rc2 Damien Le Moal
2021-11-19 22:21 ` pr-tracker-bot
-- strict thread matches above, loose matches on Subject: below --
2021-11-19 8:49 Damien Le Moal
2021-11-19 15:46 ` Sergei Shtylyov
2021-11-19 19:06 ` Linus Torvalds
2021-11-19 21:06 ` Sergei Shtylyov
2021-11-19 22:02 ` Damien Le Moal
2021-11-19 22:01 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).