From: Hannes Reinecke <hare@suse.de>
To: Damien LeMoal <damien.lemoal@wdc.com>
Cc: linux-ide@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH 02/73] libata: Add ata_port_classify() helper
Date: Wed, 8 Dec 2021 17:31:44 +0100 [thread overview]
Message-ID: <20211208163255.114660-3-hare@suse.de> (raw)
In-Reply-To: <20211208163255.114660-1-hare@suse.de>
Add an ata_port_classify() helper to print out the results from
the device classification and remove the debugging statements
from ata_dev_classify(). Also provide a mapping ata_dev_class_string()
to provide a string representation for those instances calling
ata_dev_classify() directly.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
drivers/ata/libahci.c | 2 +-
drivers/ata/libata-core.c | 67 ++++++++++++++++++++++++++++---------
drivers/ata/libata-sff.c | 2 +-
drivers/ata/sata_fsl.c | 2 +-
drivers/ata/sata_inic162x.c | 2 +-
drivers/ata/sata_sil24.c | 2 +-
include/linux/libata.h | 2 ++
7 files changed, 58 insertions(+), 21 deletions(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 8b651f55fc84..21dbcd551443 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -1300,7 +1300,7 @@ unsigned int ahci_dev_classify(struct ata_port *ap)
tf.lbal = (tmp >> 8) & 0xff;
tf.nsect = (tmp) & 0xff;
- return ata_dev_classify(&tf);
+ return ata_port_classify(ap, &tf);
}
EXPORT_SYMBOL_GPL(ahci_dev_classify);
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index f6a9e2f22a94..6cac413caf83 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -969,6 +969,27 @@ const char *sata_spd_string(unsigned int spd)
return spd_str[spd - 1];
}
+const char *ata_dev_class_string(unsigned int class)
+{
+ static const char * const class_str[] = {
+ "unknown",
+ "ATA",
+ "ATA (unsupported)",
+ "ATAPI",
+ "ATAPI (unsupported",
+ "PMP",
+ "PMP (unsupported)",
+ "SEMB",
+ "SEMB (unsupported)",
+ "ZAC",
+ "ZAC (unsupported)",
+ "none",
+ };
+ if (class == 0 || (class - 1) >= ARRAY_SIZE(class_str))
+ return "unknown";
+ return class_str[class - 1];
+}
+
/**
* ata_dev_classify - determine device type based on ATA-spec signature
* @tf: ATA taskfile register set for device to be identified
@@ -1007,36 +1028,50 @@ unsigned int ata_dev_classify(const struct ata_taskfile *tf)
* SEMB signature. This is worked around in
* ata_dev_read_id().
*/
- if ((tf->lbam == 0) && (tf->lbah == 0)) {
- DPRINTK("found ATA device by sig\n");
+ if ((tf->lbam == 0) && (tf->lbah == 0))
return ATA_DEV_ATA;
- }
- if ((tf->lbam == 0x14) && (tf->lbah == 0xeb)) {
- DPRINTK("found ATAPI device by sig\n");
+ if ((tf->lbam == 0x14) && (tf->lbah == 0xeb))
return ATA_DEV_ATAPI;
- }
- if ((tf->lbam == 0x69) && (tf->lbah == 0x96)) {
- DPRINTK("found PMP device by sig\n");
+ if ((tf->lbam == 0x69) && (tf->lbah == 0x96))
return ATA_DEV_PMP;
- }
- if ((tf->lbam == 0x3c) && (tf->lbah == 0xc3)) {
- DPRINTK("found SEMB device by sig (could be ATA device)\n");
+ if ((tf->lbam == 0x3c) && (tf->lbah == 0xc3))
return ATA_DEV_SEMB;
- }
- if ((tf->lbam == 0xcd) && (tf->lbah == 0xab)) {
- DPRINTK("found ZAC device by sig\n");
+ if ((tf->lbam == 0xcd) && (tf->lbah == 0xab))
return ATA_DEV_ZAC;
- }
- DPRINTK("unknown device\n");
return ATA_DEV_UNKNOWN;
}
EXPORT_SYMBOL_GPL(ata_dev_classify);
+/**
+ * ata_port_classify - determine device type based on ATA-spec signature
+ * @ap: ATA port device on which the classification should be run
+ * @tf: ATA taskfile register set for device to be identified
+ *
+ * A wrapper around ata_dev_classify() to provide additional logging
+ *
+ * RETURNS:
+ * Device type, %ATA_DEV_ATA, %ATA_DEV_ATAPI, %ATA_DEV_PMP,
+ * %ATA_DEV_ZAC, or %ATA_DEV_UNKNOWN the event of failure.
+ */
+unsigned int ata_port_classify(struct ata_port *ap,
+ const struct ata_taskfile *tf)
+{
+ unsigned int class = ata_dev_classify(tf);
+
+ if (class != ATA_DEV_UNKNOWN)
+ ata_port_dbg(ap, "found %s device by sig\n",
+ ata_dev_class_string(class));
+ else
+ ata_port_dbg(ap, "found unknown device\n");
+ return class;
+}
+EXPORT_SYMBOL_GPL(ata_port_classify);
+
/**
* ata_id_string - Convert IDENTIFY DEVICE page into string
* @id: IDENTIFY DEVICE results we will examine
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 39c026f3948c..a119fabe0919 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -1853,7 +1853,7 @@ unsigned int ata_sff_dev_classify(struct ata_device *dev, int present,
return ATA_DEV_NONE;
/* determine if device is ATA or ATAPI */
- class = ata_dev_classify(&tf);
+ class = ata_port_classify(ap, &tf);
if (class == ATA_DEV_UNKNOWN) {
/* If the device failed diagnostic, it's likely to
diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index e5838b23c9e0..dbc57b7a58b8 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -812,7 +812,7 @@ static unsigned int sata_fsl_dev_classify(struct ata_port *ap)
tf.lbal = (temp >> 8) & 0xff;
tf.nsect = temp & 0xff;
- return ata_dev_classify(&tf);
+ return ata_port_classify(ap, &tf);
}
static int sata_fsl_hardreset(struct ata_link *link, unsigned int *class,
diff --git a/drivers/ata/sata_inic162x.c b/drivers/ata/sata_inic162x.c
index e517bd8822a5..b6239dae524a 100644
--- a/drivers/ata/sata_inic162x.c
+++ b/drivers/ata/sata_inic162x.c
@@ -657,7 +657,7 @@ static int inic_hardreset(struct ata_link *link, unsigned int *class,
}
inic_tf_read(ap, &tf);
- *class = ata_dev_classify(&tf);
+ *class = ata_port_classify(ap, &tf);
}
return 0;
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index f99ec6f7d7c0..7e9c1945dc81 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -680,7 +680,7 @@ static int sil24_softreset(struct ata_link *link, unsigned int *class,
}
sil24_read_tf(ap, 0, &tf);
- *class = ata_dev_classify(&tf);
+ *class = ata_port_classify(ap, &tf);
DPRINTK("EXIT, class=%u\n", *class);
return 0;
diff --git a/include/linux/libata.h b/include/linux/libata.h
index 2a8404b26083..235fdbeb19ea 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -1160,6 +1160,8 @@ extern enum ata_completion_errors ata_noop_qc_prep(struct ata_queued_cmd *qc);
extern void ata_sg_init(struct ata_queued_cmd *qc, struct scatterlist *sg,
unsigned int n_elem);
extern unsigned int ata_dev_classify(const struct ata_taskfile *tf);
+extern unsigned int ata_port_classify(struct ata_port *ap,
+ const struct ata_taskfile *tf);
extern void ata_dev_disable(struct ata_device *adev);
extern void ata_id_string(const u16 *id, unsigned char *s,
unsigned int ofs, unsigned int len);
--
2.29.2
next prev parent reply other threads:[~2021-12-08 16:33 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 16:31 [PATCH 00/73] libata: rework logging, take II Hannes Reinecke
2021-12-08 16:31 ` [PATCH 01/73] libata: remove pointless debugging messages Hannes Reinecke
2021-12-08 16:31 ` Hannes Reinecke [this message]
2021-12-09 0:34 ` [PATCH 02/73] libata: Add ata_port_classify() helper Damien Le Moal
2021-12-09 7:16 ` Hannes Reinecke
2021-12-08 16:31 ` [PATCH 03/73] libata: move ata_dump_id() to dynamic debugging Hannes Reinecke
2021-12-08 16:31 ` [PATCH 04/73] libata: sanitize ATA_HORKAGE_DUMP_ID Hannes Reinecke
2021-12-08 16:31 ` [PATCH 05/73] sata_mv: replace DPRINTK with 'pci_dump' module parameter Hannes Reinecke
2021-12-09 0:38 ` Damien Le Moal
2021-12-09 7:17 ` Hannes Reinecke
2021-12-09 8:10 ` Damien Le Moal
2021-12-08 16:31 ` [PATCH 06/73] sata_mv: kill 'port' argument in mv_dump_all_regs() Hannes Reinecke
2021-12-09 0:40 ` Damien Le Moal
2021-12-09 8:19 ` Hannes Reinecke
2021-12-08 16:31 ` [PATCH 07/73] libata: add reset tracepoints Hannes Reinecke
2021-12-08 16:31 ` [PATCH 08/73] libata: drop DPRINTK() calls in reset Hannes Reinecke
2021-12-09 0:47 ` Damien Le Moal
2021-12-08 16:31 ` [PATCH 09/73] libata: tracepoints for bus-master DMA Hannes Reinecke
2021-12-08 16:31 ` [PATCH 10/73] libata: drop debugging statements " Hannes Reinecke
2021-12-09 0:46 ` Damien Le Moal
2021-12-09 8:20 ` Hannes Reinecke
2021-12-08 16:31 ` [PATCH 11/73] pata_octeon_cf: add bmdma tracepoints and drop DPRINTK() calls Hannes Reinecke
2021-12-08 16:31 ` [PATCH 12/73] pata_arasan_cf: use generic tracepoints Hannes Reinecke
2021-12-08 16:31 ` [PATCH 13/73] sata_dwc_460ex: " Hannes Reinecke
2021-12-08 16:31 ` [PATCH 14/73] sata_nv: " Hannes Reinecke
2021-12-08 16:31 ` [PATCH 15/73] libata-sff: tracepoints for HSM state machine Hannes Reinecke
2021-12-08 16:31 ` [PATCH 16/73] libata-sff: add tracepoints for ata_sff_flush_pio_task() Hannes Reinecke
2021-12-08 16:31 ` [PATCH 17/73] libata-scsi: drop DPRINTK calls for cdb translation Hannes Reinecke
2021-12-08 16:32 ` [PATCH 18/73] libata: add tracepoints for ATA error handling Hannes Reinecke
2021-12-08 16:32 ` [PATCH 19/73] libata: drop DPRINTK() calls during " Hannes Reinecke
2021-12-09 0:50 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 20/73] libata-eh: remove DPRINTK() calls for request sense Hannes Reinecke
2021-12-09 0:51 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 21/73] libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros Hannes Reinecke
2021-12-09 0:57 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 22/73] libata: add qc_prep tracepoint Hannes Reinecke
2021-12-09 8:42 ` Sergei Shtylyov
2021-12-09 11:14 ` Hannes Reinecke
2021-12-09 12:47 ` Sergei Shtylyov
2021-12-08 16:32 ` [PATCH 23/73] libata: move DPRINTK to ata debugging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 24/73] pata_octeon_cf: remove DPRINTK() macro in interrupt context Hannes Reinecke
2021-12-09 0:58 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 25/73] pdc_adma: Remove DPRINTK call Hannes Reinecke
2021-12-08 16:32 ` [PATCH 26/73] sata_fsl: move DPRINTK to ata debugging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 27/73] sata_rcar: replace DPRINTK() with ata_port_dbg() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 28/73] sata_qstor: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 29/73] pata_pdc2027x: Replace PDPRINTK() with standard ata logging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 30/73] libata: remove pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 31/73] ahci: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-08 16:32 ` [PATCH 32/73] pdc_adma: " Hannes Reinecke
2021-12-09 1:01 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 33/73] pata_octeon_cf: " Hannes Reinecke
2021-12-09 8:39 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 34/73] pata_via: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 35/73] sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-09 6:13 ` Mikael Pettersson
2021-12-08 16:32 ` [PATCH 36/73] sata_qstor: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 37/73] sata_rcar: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 38/73] sata_inic162x: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 39/73] sata_mv: Drop pointless VPRINTK() call and convert the remaining one Hannes Reinecke
2021-12-08 16:32 ` [PATCH 40/73] sata_nv: drop pointless VPRINTK() calls and convert remaining ones Hannes Reinecke
2021-12-08 16:32 ` [PATCH 41/73] sata_fsl: convert VPRINTK() calls to ata_port_dbg() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 42/73] sata_sil: Drop pointless VPRINTK() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 43/73] sata_sx4: Drop pointless VPRINTK() calls and convert the remaining ones Hannes Reinecke
2021-12-08 16:32 ` [PATCH 44/73] sata_sx4: add module parameter 'dimm_test' Hannes Reinecke
2021-12-08 16:32 ` [PATCH 45/73] libata: drop ata_msg_error() and ata_msg_intr() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 46/73] libata: drop ata_msg_ctl() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 47/73] libata: drop ata_msg_malloc() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 48/73] libata: drop ata_msg_warn() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 49/73] libata: drop ata_msg_probe() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 50/73] libata: drop ata_msg_info() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 51/73] libata: drop ata_msg_drv() Hannes Reinecke
2021-12-08 16:32 ` [PATCH 52/73] libata: remove 'new' ata message handling Hannes Reinecke
2021-12-08 16:32 ` [PATCH 53/73] libata: remove debug compilation switches Hannes Reinecke
2021-12-08 16:32 ` [PATCH 54/73] pata_atp867x: convert blank printk() calls Hannes Reinecke
2021-12-09 1:08 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 55/73] pata_cmd640: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 56/73] pata_cmd64x: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 57/73] pata_cs5520: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 58/73] pata_cs5536: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 59/73] pata_cypressx: " Hannes Reinecke
2021-12-09 8:25 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 60/73] pata_it821x: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 61/73] pata_marvell: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 62/73] pata_rz1000: " Hannes Reinecke
2021-12-09 1:10 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 63/73] pata_serverworks: " Hannes Reinecke
2021-12-08 16:32 ` [PATCH 64/73] pata_sil680: " Hannes Reinecke
2021-12-09 8:24 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 65/73] pdc_adma: remove disabled debugging messages Hannes Reinecke
2021-12-08 16:32 ` [PATCH 66/73] sata_sx4: convert blank printk() calls Hannes Reinecke
2021-12-08 16:32 ` [PATCH 67/73] sata_mv: convert remaining printk() to structured logging Hannes Reinecke
2021-12-08 16:32 ` [PATCH 68/73] pata_hpt37x: convert pr_XXX() calls Hannes Reinecke
2021-12-09 1:13 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 69/73] pata_octeon_cf: Replace pr_XXX() calls with structured logging Hannes Reinecke
2021-12-09 8:08 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 70/73] pata_hpt3x2n: convert pr_XXX() calls Hannes Reinecke
2021-12-09 1:13 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 71/73] pata_hpt3x2n: convert pr_err() calls Hannes Reinecke
2021-12-09 1:14 ` Damien Le Moal
2021-12-09 8:09 ` Sergey Shtylyov
2021-12-08 16:32 ` [PATCH 72/73] pata_hpt366: convert pr_warn() calls Hannes Reinecke
2021-12-09 1:14 ` Damien Le Moal
2021-12-08 16:32 ` [PATCH 73/73] libata-scsi: rework ata_dump_status to avoid using pr_cont() Hannes Reinecke
2021-12-09 1:17 ` [PATCH 00/73] libata: rework logging, take II Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208163255.114660-3-hare@suse.de \
--to=hare@suse.de \
--cc=b.zolnierkie@samsung.com \
--cc=damien.lemoal@wdc.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).