Re: [PATCH 72/73] pata_hpt366: convert pr_warn() calls

[Damien Le Moal <damien.lemoal@opensource.wdc.com>]

On 2021/12/09 1:32, Hannes Reinecke wrote:
> Convert pr_warn() calls to ata_dev_warn()
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/ata/pata_hpt366.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/pata_hpt366.c b/drivers/ata/pata_hpt366.c
> index 06b7c4a9ec95..c29863038428 100644
> --- a/drivers/ata/pata_hpt366.c
> +++ b/drivers/ata/pata_hpt366.c
> @@ -15,8 +15,6 @@
>   *	Look into engine reset on timeout errors. Should not be required.
>   */
>  

Remove the above blank line.

> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> @@ -183,7 +181,7 @@ static int hpt_dma_blacklisted(const struct ata_device *dev, char *modestr,
>  
>  	i = match_string(list, -1, model_num);
>  	if (i >= 0) {
> -		pr_warn("%s is not supported for %s\n", modestr, list[i]);
> +		ata_dev_warn(dev, "%s is not supported for %s\n", modestr, list[i]);
>  		return 1;
>  	}
>  	return 0;
> 


-- 
Damien Le Moal
Western Digital Research