Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ahci: Remove the exporting of ahci_em_messages
@ 2019-07-10 15:29 Denis Efremov
  2019-07-11  1:03 ` Liu, Chuansheng
  0 siblings, 1 reply; 3+ messages in thread
From: Denis Efremov @ 2019-07-10 15:29 UTC (permalink / raw)
  To: Chuansheng Liu; +Cc: Denis Efremov, Jens Axboe, linux-ide, linux-kernel

The variable ahci_em_messages is declared static and marked
EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
variable is not used outside of the drivers/ata/libahci.c file it is
defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Fixes: ed08d40cdec4 ("ahci: Changing two module params with static and __read_mostly")
Signed-off-by: Denis Efremov <efremov@linux.com>
---
 drivers/ata/libahci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index e4c45d3cca79..bff369d9a1a7 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -175,7 +175,6 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
 EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
 
 static bool ahci_em_messages __read_mostly = true;
-EXPORT_SYMBOL_GPL(ahci_em_messages);
 module_param(ahci_em_messages, bool, 0444);
 /* add other LED protocol types when they become supported */
 MODULE_PARM_DESC(ahci_em_messages,
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] ahci: Remove the exporting of ahci_em_messages
  2019-07-10 15:29 [PATCH] ahci: Remove the exporting of ahci_em_messages Denis Efremov
@ 2019-07-11  1:03 ` Liu, Chuansheng
  2019-08-13 21:44   ` Denis Efremov
  0 siblings, 1 reply; 3+ messages in thread
From: Liu, Chuansheng @ 2019-07-11  1:03 UTC (permalink / raw)
  To: Denis Efremov; +Cc: Jens Axboe, linux-ide, linux-kernel



> -----Original Message-----
> From: Denis Efremov [mailto:efremov@linux.com]
> Sent: Wednesday, July 10, 2019 11:29 PM
> To: Liu, Chuansheng <chuansheng.liu@intel.com>
> Cc: Denis Efremov <efremov@linux.com>; Jens Axboe <axboe@kernel.dk>;
> linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
> 
> The variable ahci_em_messages is declared static and marked
> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
> variable is not used outside of the drivers/ata/libahci.c file it is
> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.

Sounds good to me, thanks.
Reviewed-by: Chuansheng Liu <chuansheng.liu@linux.intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ahci: Remove the exporting of ahci_em_messages
  2019-07-11  1:03 ` Liu, Chuansheng
@ 2019-08-13 21:44   ` Denis Efremov
  0 siblings, 0 replies; 3+ messages in thread
From: Denis Efremov @ 2019-08-13 21:44 UTC (permalink / raw)
  To: Jens Axboe; +Cc: Liu, Chuansheng, linux-ide, linux-kernel, Masahiro Yamada

Hi Jens,

On 11.07.2019 04:03, Liu, Chuansheng wrote:
>> -----Original Message-----
>> From: Denis Efremov [mailto:efremov@linux.com]
>> Sent: Wednesday, July 10, 2019 11:29 PM
>> To: Liu, Chuansheng <chuansheng.liu@intel.com>
>> Cc: Denis Efremov <efremov@linux.com>; Jens Axboe <axboe@kernel.dk>;
>> linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>>
>> The variable ahci_em_messages is declared static and marked
>> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
>> variable is not used outside of the drivers/ata/libahci.c file it is
>> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
> 
> Sounds good to me, thanks.
> Reviewed-by: Chuansheng Liu <chuansheng.liu@linux.intel.com>
> 

Could you please look at this patch once again and accept it if it's ok?
static ahci_em_messages will trigger a warning after this check
will be in tree https://lkml.org/lkml/2019/7/14/118

Thanks,
Denis

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-10 15:29 [PATCH] ahci: Remove the exporting of ahci_em_messages Denis Efremov
2019-07-11  1:03 ` Liu, Chuansheng
2019-08-13 21:44   ` Denis Efremov

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org linux-ide@archiver.kernel.org
	public-inbox-index linux-ide


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/ public-inbox