From: Sergey Shtylyov <s.shtylyov@omprussia.ru>
To: Jens Axboe <axboe@kernel.dk>, <linux-ide@vger.kernel.org>
Subject: [PATCH v2] pata_ep93xx: fix deferred probing
Date: Sat, 20 Mar 2021 23:32:38 +0300 [thread overview]
Message-ID: <509fda88-2e0d-2cc7-f411-695d7e94b136@omprussia.ru> (raw)
The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
permanently instead of the deferred probing. Propagate the error code
upstream, as it should have been done from the start...
Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
---
This patch is against the 'master' branch of Jens Axboe's 'linux-block.git'
repo.
Changes in version 2:
- split off the part fixing up IRQ0 case, adjusted the description accordingly.
drivers/ata/pata_ep93xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-block/drivers/ata/pata_ep93xx.c
===================================================================
--- linux-block.orig/drivers/ata/pata_ep93xx.c
+++ linux-block/drivers/ata/pata_ep93xx.c
@@ -928,7 +928,7 @@ static int ep93xx_pata_probe(struct plat
/* INT[3] (IRQ_EP93XX_EXT3) line connected as pull down */
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- err = -ENXIO;
+ err = irq;
goto err_rel_gpio;
}
next reply other threads:[~2021-03-20 20:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 20:32 Sergey Shtylyov [this message]
2021-05-27 18:39 ` [PATCH v2] pata_ep93xx: fix deferred probing Sergey Shtylyov
2021-05-27 19:03 ` Jens Axboe
2021-05-27 19:10 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509fda88-2e0d-2cc7-f411-695d7e94b136@omprussia.ru \
--to=s.shtylyov@omprussia.ru \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).