[PATCH v2] pata_ep93xx: fix deferred probing

[PATCH v2] pata_ep93xx: fix deferred probing

[Sergey Shtylyov]

The driver overrides the error codes returned by platform_get_irq() to
-ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
permanently instead of the deferred probing.  Propagate the error code
upstream, as it should have been done from the start...

Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>

---
This patch is against the 'master' branch of Jens Axboe's 'linux-block.git'
repo.

Changes in version 2:
- split off the part fixing up IRQ0 case, adjusted the description accordingly.

 drivers/ata/pata_ep93xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-block/drivers/ata/pata_ep93xx.c
===================================================================
--- linux-block.orig/drivers/ata/pata_ep93xx.c
+++ linux-block/drivers/ata/pata_ep93xx.c
@@ -928,7 +928,7 @@ static int ep93xx_pata_probe(struct plat
 	/* INT[3] (IRQ_EP93XX_EXT3) line connected as pull down */
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		err = -ENXIO;
+		err = irq;
 		goto err_rel_gpio;
 	}
 

Re: [PATCH v2] pata_ep93xx: fix deferred probing

[Sergey Shtylyov]

Hello!

On 3/20/21 11:32 PM, Sergey Shtylyov wrote:

> The driver overrides the error codes returned by platform_get_irq() to
> -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
> permanently instead of the deferred probing.  Propagate the error code
> upstream, as it should have been done from the start...
> 
> Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>

   Again, 2 months has passed and no feedback whatsoever... the patch has fell
thru the cracks?

MBR, Sergey

Re: [PATCH v2] pata_ep93xx: fix deferred probing

[Jens Axboe]

On 5/27/21 12:39 PM, Sergey Shtylyov wrote:
> Hello!
> 
> On 3/20/21 11:32 PM, Sergey Shtylyov wrote:
> 
>> The driver overrides the error codes returned by platform_get_irq() to
>> -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
>> permanently instead of the deferred probing.  Propagate the error code
>> upstream, as it should have been done from the start...
>>
>> Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
> 
>    Again, 2 months has passed and no feedback whatsoever... the patch has fell
> thru the cracks?

It'd help if you sent out patches like this in a series, instead of
individual ones, when they are addressing the same issue across
multiple drivers. Makes the risk of them getting lost much smaller.

That said, I'll apply this one, thanks.

-- 
Jens Axboe

Re: [PATCH v2] pata_ep93xx: fix deferred probing

[Sergey Shtylyov]

On 5/27/21 10:03 PM, Jens Axboe wrote:

[...]
>>> The driver overrides the error codes returned by platform_get_irq() to
>>> -ENXIO, so if it returns -EPROBE_DEFER, the driver would fail the probe
>>> permanently instead of the deferred probing.  Propagate the error code
>>> upstream, as it should have been done from the start...
>>>
>>> Fixes: 2fff27512600 ("PATA host controller driver for ep93xx")
>>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
>>
>>    Again, 2 months has passed and no feedback whatsoever... the patch has fell
>> thru the cracks?

   Sorry for the wrong tenses -- forgot to re-read after editing. :-)

> It'd help if you sent out patches like this in a series, instead of
> individual ones, when they are addressing the same issue across
> multiple drivers. Makes the risk of them getting lost much smaller.

   That's what I try to do,. generally. Not sure how these 3 patches
ended up being all on their own... :-/

> That said, I'll apply this one, thanks.

   Thanx! :-)

MBR, Sergey