Linux-ide Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v1] ahci: Do not export local variable ahci_em_messages
@ 2019-08-30 19:42 Andy Shevchenko
  2019-08-30 20:26 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2019-08-30 19:42 UTC (permalink / raw)
  To: Jens Axboe, linux-ide; +Cc: Andy Shevchenko, Chuansheng Liu

The commit ed08d40cdec4
  ("ahci: Changing two module params with static and __read_mostly")
moved ahci_em_messages to be static while missing the fact of exporting it.

WARNING: "ahci_em_messages" [vmlinux] is a static EXPORT_SYMBOL_GPL

Drop export for the local variable ahci_em_messages.

Fixes: ed08d40cdec4 ("ahci: Changing two module params with static and __read_mostly")
Cc: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/ata/libahci.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index e4c45d3cca79..bff369d9a1a7 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -175,7 +175,6 @@ struct ata_port_operations ahci_pmp_retry_srst_ops = {
 EXPORT_SYMBOL_GPL(ahci_pmp_retry_srst_ops);
 
 static bool ahci_em_messages __read_mostly = true;
-EXPORT_SYMBOL_GPL(ahci_em_messages);
 module_param(ahci_em_messages, bool, 0444);
 /* add other LED protocol types when they become supported */
 MODULE_PARM_DESC(ahci_em_messages,
-- 
2.23.0.rc1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] ahci: Do not export local variable ahci_em_messages
  2019-08-30 19:42 [PATCH v1] ahci: Do not export local variable ahci_em_messages Andy Shevchenko
@ 2019-08-30 20:26 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-08-30 20:26 UTC (permalink / raw)
  To: Andy Shevchenko, linux-ide; +Cc: Chuansheng Liu

On 8/30/19 1:42 PM, Andy Shevchenko wrote:
> The commit ed08d40cdec4
>    ("ahci: Changing two module params with static and __read_mostly")
> moved ahci_em_messages to be static while missing the fact of exporting it.
> 
> WARNING: "ahci_em_messages" [vmlinux] is a static EXPORT_SYMBOL_GPL
> 
> Drop export for the local variable ahci_em_messages.

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-30 19:42 [PATCH v1] ahci: Do not export local variable ahci_em_messages Andy Shevchenko
2019-08-30 20:26 ` Jens Axboe

Linux-ide Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-ide/0 linux-ide/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-ide linux-ide/ https://lore.kernel.org/linux-ide \
		linux-ide@vger.kernel.org linux-ide@archiver.kernel.org
	public-inbox-index linux-ide


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-ide


AGPL code for this site: git clone https://public-inbox.org/ public-inbox