From: Finn Thain <fthain@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_falcon: Add missing __iomem annotations
Date: Thu, 25 Nov 2021 12:09:41 +1100 (AEDT) [thread overview]
Message-ID: <682664c-836e-ae61-6844-207a980f9cd@linux-m68k.org> (raw)
In-Reply-To: <f420bff8-855a-aabe-924c-6d1b74f11001@gmail.com>
On Wed, 24 Nov 2021, Michael Schmitz wrote:
> On 24/11/21 17:25, Finn Thain wrote:
> > The zero day bot reported some sparse complaints in pata_falcon.c. E.g.
> >
> > drivers/ata/pata_falcon.c:58:41: warning: cast removes address space
> > '__iomem' of expression
> > drivers/ata/pata_falcon.c:58:41: warning: incorrect type in argument 1
> > (different address spaces)
> > drivers/ata/pata_falcon.c:58:41: expected unsigned short volatile
> > [noderef] [usertype] __iomem *port
> > drivers/ata/pata_falcon.c:58:41: got unsigned short [usertype] *
> >
> > The same thing shows up in 8 places, all told. Avoid this by use of
> > __iomem type casts.
>
> Seeing as data_addr was explicitly typed as __iomem, your fix is clearly
> correct. Bit embarrassing to have missed that (I remember adding __iomem
> annotations elsewhere at some stage).
>
> If you think there's any need to test this change, say so.
>
There's no change in pata_falcon.o.
> Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
>
Thanks.
next prev parent reply other threads:[~2021-11-25 1:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 4:25 [PATCH] pata_falcon: Add missing __iomem annotations Finn Thain
2021-11-24 4:52 ` Michael Schmitz
2021-11-25 1:09 ` Finn Thain [this message]
2021-11-24 7:51 ` Geert Uytterhoeven
2021-11-24 20:50 ` Michael Schmitz
2021-11-25 7:33 ` Geert Uytterhoeven
2021-11-25 1:06 ` Finn Thain
2021-11-25 7:39 ` Geert Uytterhoeven
2021-11-25 22:36 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682664c-836e-ae61-6844-207a980f9cd@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).