From: Finn Thain <fthain@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Michael Schmitz <schmitzmic@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pata_falcon: Add missing __iomem annotations
Date: Fri, 26 Nov 2021 09:36:56 +1100 (AEDT) [thread overview]
Message-ID: <9713ea83-b4e7-4eee-5ab1-7fb2dccb4ccd@linux-m68k.org> (raw)
In-Reply-To: <CAMuHMdXy-XyR5PtczK9J1p_i=jugp4yq6JF8_MhVC1FMK5dtPw@mail.gmail.com>
On Thu, 25 Nov 2021, Geert Uytterhoeven wrote:
>
> Yeah, you do have to be careful with macros that derive a size from the
> type of the passed data. The *{in,out}sw() functions do not suffer from
> that: they are defined to operate on a 16-bit I/O register. It is very
> unlikely these semantics will ever change.
>
> Here I'm more worried about the other danger: keeping casts will silence
> any warning that may be introduced in a future change to the driver
> code.
>
Fair enough. I'll send v2.
prev parent reply other threads:[~2021-11-25 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 4:25 [PATCH] pata_falcon: Add missing __iomem annotations Finn Thain
2021-11-24 4:52 ` Michael Schmitz
2021-11-25 1:09 ` Finn Thain
2021-11-24 7:51 ` Geert Uytterhoeven
2021-11-24 20:50 ` Michael Schmitz
2021-11-25 7:33 ` Geert Uytterhoeven
2021-11-25 1:06 ` Finn Thain
2021-11-25 7:39 ` Geert Uytterhoeven
2021-11-25 22:36 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9713ea83-b4e7-4eee-5ab1-7fb2dccb4ccd@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=geert@linux-m68k.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).