From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Tim Waugh <tim@cyberelk.net>, Borislav Petkov <bp@alien8.de>,
Jan Kara <jack@suse.com>,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH 5/7] hfsplus: stop using ioctl_by_bdev
Date: Mon, 4 May 2020 10:41:55 -0600 [thread overview]
Message-ID: <6cbb8166-a419-9322-78ee-51fbec22b59d@kernel.dk> (raw)
In-Reply-To: <20200504162114.GA637@lst.de>
On 5/4/20 10:21 AM, Christoph Hellwig wrote:
> On Mon, May 04, 2020 at 10:16:40AM -0600, Jens Axboe wrote:
>> On 4/25/20 1:57 AM, Christoph Hellwig wrote:
>>> if (HFSPLUS_SB(sb)->session >= 0) {
>>> + struct cdrom_tocentry te;
>>> +
>>> + if (!cdi)
>>> + return -EINVAL;
>>> +
>>> te.cdte_track = HFSPLUS_SB(sb)->session;
>>> te.cdte_format = CDROM_LBA;
>>> - res = ioctl_by_bdev(sb->s_bdev,
>>> - CDROMREADTOCENTRY, (unsigned long)&te);
>>> - if (!res && (te.cdte_ctrl & CDROM_DATA_TRACK) == 4) {
>>> - *start = (sector_t)te.cdte_addr.lba << 2;
>>> - return 0;
>>> + if (cdrom_read_tocentry(cdi, &te) ||
>>> + (te.cdte_ctrl & CDROM_DATA_TRACK) != 4) {
>>> + pr_err("invalid session number or type of track\n");
>>> + return -EINVAL;
>>> }
>>
>> I must be missing something obvious from just looking over the patches,
>> but how does this work if cdrom is modular and hfsplus is builtin?
>
> In that case disk_to_cdi will return NULL as it uses IS_REACHABLE
> and the file systems won't query the CD-ROM specific information.
Got it, looks like that'll do the trick without nasty Kconfig
dependencies.
--
Jens Axboe
next prev parent reply other threads:[~2020-05-04 16:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 7:56 stop using ioctl_by_bdev for file system access to CDROMs v2 Christoph Hellwig
2020-04-25 7:57 ` [PATCH 1/7] block: add a cdrom_device_info pointer to struct gendisk Christoph Hellwig
2020-04-27 6:15 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 2/7] ide-cd: rename cdrom_read_tocentry Christoph Hellwig
2020-04-27 6:16 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 3/7] cdrom: factor out a cdrom_read_tocentry helper Christoph Hellwig
2020-04-27 6:17 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 4/7] cdrom: factor out a cdrom_multisession helper Christoph Hellwig
2020-04-27 6:17 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 5/7] hfsplus: stop using ioctl_by_bdev Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-05-04 16:16 ` Jens Axboe
2020-05-04 16:21 ` Christoph Hellwig
2020-05-04 16:41 ` Jens Axboe [this message]
2020-04-25 7:57 ` [PATCH 6/7] isofs: " Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-04-27 9:50 ` Jan Kara
2020-04-25 7:57 ` [PATCH 7/7] udf: " Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-04-28 6:53 ` stop using ioctl_by_bdev for file system access to CDROMs v2 Christoph Hellwig
2020-05-04 16:42 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2020-04-23 7:12 stop using ioctl_by_bdev for file system access to CDROMs Christoph Hellwig
2020-04-23 7:12 ` [PATCH 5/7] hfsplus: stop using ioctl_by_bdev Christoph Hellwig
2020-04-23 7:42 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cbb8166-a419-9322-78ee-51fbec22b59d@kernel.dk \
--to=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).