From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: Tim Waugh <tim@cyberelk.net>, Borislav Petkov <bp@alien8.de>,
Jan Kara <jack@suse.com>,
linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: stop using ioctl_by_bdev for file system access to CDROMs v2
Date: Mon, 4 May 2020 10:42:07 -0600 [thread overview]
Message-ID: <c89a895d-6bc0-c563-ad51-9204656b30b5@kernel.dk> (raw)
In-Reply-To: <20200425075706.721917-1-hch@lst.de>
On 4/25/20 1:56 AM, Christoph Hellwig wrote:
> Hi Jens,
>
> except for the DASD case under discussion the last users of ioctl_by_bdev
> are the file system drivers that want to query CDROM information using
> ioctls. This series switches them to use function calls directly into
> the CDROM midlayer instead, which implies:
>
> - adding a cdrom_device_info pointer to the gendisk, so that file systems
> can find it without going to the low-level driver first
> - ensuring that the CDROM midlayer (which isn't a lot of code) is built
> in if the file systems are built in so that they can actually call the
> exported functions
>
> Changes since v1:
> - fix up the no-CDROM error case in isofs_get_last_session to return 0
> instead of -EINVAL.
Applied for 5.8, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-05-04 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 7:56 stop using ioctl_by_bdev for file system access to CDROMs v2 Christoph Hellwig
2020-04-25 7:57 ` [PATCH 1/7] block: add a cdrom_device_info pointer to struct gendisk Christoph Hellwig
2020-04-27 6:15 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 2/7] ide-cd: rename cdrom_read_tocentry Christoph Hellwig
2020-04-27 6:16 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 3/7] cdrom: factor out a cdrom_read_tocentry helper Christoph Hellwig
2020-04-27 6:17 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 4/7] cdrom: factor out a cdrom_multisession helper Christoph Hellwig
2020-04-27 6:17 ` Hannes Reinecke
2020-04-25 7:57 ` [PATCH 5/7] hfsplus: stop using ioctl_by_bdev Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-05-04 16:16 ` Jens Axboe
2020-05-04 16:21 ` Christoph Hellwig
2020-05-04 16:41 ` Jens Axboe
2020-04-25 7:57 ` [PATCH 6/7] isofs: " Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-04-27 9:50 ` Jan Kara
2020-04-25 7:57 ` [PATCH 7/7] udf: " Christoph Hellwig
2020-04-27 6:18 ` Hannes Reinecke
2020-04-28 6:53 ` stop using ioctl_by_bdev for file system access to CDROMs v2 Christoph Hellwig
2020-05-04 16:42 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c89a895d-6bc0-c563-ad51-9204656b30b5@kernel.dk \
--to=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).