* [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
[not found] <20190102181038.4418-1-okaya@kernel.org>
@ 2019-01-02 18:10 ` Sinan Kaya
2019-01-07 11:12 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Sinan Kaya @ 2019-01-02 18:10 UTC (permalink / raw)
To: linux-next
Cc: linux-acpi, Sinan Kaya, Jens Axboe,
open list:LIBATA SUBSYSTEM Serial and Parallel ATA drivers,
open list
After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. PATA_ACPI is a PCI device driver but the PCI
dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
drivers/ata/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 4ca7a6b4eaae..8218db17ebdb 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
config PATA_ACPI
tristate "ACPI firmware driver for PATA"
- depends on ATA_ACPI && ATA_BMDMA
+ depends on ATA_ACPI && ATA_BMDMA && PCI
help
This option enables an ACPI method driver which drives
motherboard PATA controller interfaces through the ACPI
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit Sinan Kaya
@ 2019-01-07 11:12 ` Rafael J. Wysocki
[not found] ` <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 11:12 UTC (permalink / raw)
To: Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. PATA_ACPI is a PCI device driver but the PCI
> dependency has not been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> drivers/ata/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 4ca7a6b4eaae..8218db17ebdb 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>
> config PATA_ACPI
> tristate "ACPI firmware driver for PATA"
> - depends on ATA_ACPI && ATA_BMDMA
> + depends on ATA_ACPI && ATA_BMDMA && PCI
> help
> This option enables an ACPI method driver which drives
> motherboard PATA controller interfaces through the ACPI
> --
Any objections against this one from anyone?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
[not found] ` <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
@ 2019-01-07 14:17 ` Bartlomiej Zolnierkiewicz
2019-01-07 15:41 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-01-07 14:17 UTC (permalink / raw)
To: Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List, Jens Axboe,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On 01/07/2019 12:12 PM, Rafael J. Wysocki wrote:
> On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
>>
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly. PATA_ACPI is a PCI device driver but the PCI
>> dependency has not been explicitly called out.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>> ---
>> drivers/ata/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 4ca7a6b4eaae..8218db17ebdb 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>>
>> config PATA_ACPI
>> tristate "ACPI firmware driver for PATA"
>> - depends on ATA_ACPI && ATA_BMDMA
>> + depends on ATA_ACPI && ATA_BMDMA && PCI
>> help
>> This option enables an ACPI method driver which drives
>> motherboard PATA controller interfaces through the ACPI
>> --
>
> Any objections against this one from anyone?
Patch looks correct to me (pata_acpi is indeed a PCI driver):
Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
but it is best to wait for Jens' ACK if you want to merge it
through ACPI tree..
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
2019-01-07 14:17 ` Bartlomiej Zolnierkiewicz
@ 2019-01-07 15:41 ` Jens Axboe
2019-01-07 17:52 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2019-01-07 15:41 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Rafael J. Wysocki, Sinan Kaya
Cc: Linux-Next Mailing List, ACPI Devel Maling List,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On 1/7/19 7:17 AM, Bartlomiej Zolnierkiewicz wrote:
>
> On 01/07/2019 12:12 PM, Rafael J. Wysocki wrote:
>> On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
>>>
>>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>>> specified directly. PATA_ACPI is a PCI device driver but the PCI
>>> dependency has not been explicitly called out.
>>>
>>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>> ---
>>> drivers/ata/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>>> index 4ca7a6b4eaae..8218db17ebdb 100644
>>> --- a/drivers/ata/Kconfig
>>> +++ b/drivers/ata/Kconfig
>>> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>>>
>>> config PATA_ACPI
>>> tristate "ACPI firmware driver for PATA"
>>> - depends on ATA_ACPI && ATA_BMDMA
>>> + depends on ATA_ACPI && ATA_BMDMA && PCI
>>> help
>>> This option enables an ACPI method driver which drives
>>> motherboard PATA controller interfaces through the ACPI
>>> --
>>
>> Any objections against this one from anyone?
>
> Patch looks correct to me (pata_acpi is indeed a PCI driver):
>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>
> but it is best to wait for Jens' ACK if you want to merge it
> through ACPI tree..
You can add my:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
if you want to merge it through the ACPI tree.
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit
2019-01-07 15:41 ` Jens Axboe
@ 2019-01-07 17:52 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2019-01-07 17:52 UTC (permalink / raw)
To: Jens Axboe
Cc: Bartlomiej Zolnierkiewicz, Rafael J. Wysocki, Sinan Kaya,
Linux-Next Mailing List, ACPI Devel Maling List,
open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers),
open list
On Mon, Jan 7, 2019 at 4:42 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 1/7/19 7:17 AM, Bartlomiej Zolnierkiewicz wrote:
> >
> > On 01/07/2019 12:12 PM, Rafael J. Wysocki wrote:
> >> On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@kernel.org> wrote:
> >>>
> >>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> >>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> >>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> >>> specified directly. PATA_ACPI is a PCI device driver but the PCI
> >>> dependency has not been explicitly called out.
> >>>
> >>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> >>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> >>> ---
> >>> drivers/ata/Kconfig | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> >>> index 4ca7a6b4eaae..8218db17ebdb 100644
> >>> --- a/drivers/ata/Kconfig
> >>> +++ b/drivers/ata/Kconfig
> >>> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
> >>>
> >>> config PATA_ACPI
> >>> tristate "ACPI firmware driver for PATA"
> >>> - depends on ATA_ACPI && ATA_BMDMA
> >>> + depends on ATA_ACPI && ATA_BMDMA && PCI
> >>> help
> >>> This option enables an ACPI method driver which drives
> >>> motherboard PATA controller interfaces through the ACPI
> >>> --
> >>
> >> Any objections against this one from anyone?
> >
> > Patch looks correct to me (pata_acpi is indeed a PCI driver):
> >
> > Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> >
> > but it is best to wait for Jens' ACK if you want to merge it
> > through ACPI tree..
>
> You can add my:
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>
> if you want to merge it through the ACPI tree.
I will do that, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-07 17:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190102181038.4418-1-okaya@kernel.org>
2019-01-02 18:10 ` [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit Sinan Kaya
2019-01-07 11:12 ` Rafael J. Wysocki
[not found] ` <CGME20190107141740eucas1p15f2975c3d87e7a8fce9daeaea41525d4@eucas1p1.samsung.com>
2019-01-07 14:17 ` Bartlomiej Zolnierkiewicz
2019-01-07 15:41 ` Jens Axboe
2019-01-07 17:52 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).