linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] pata_cmd64x: Use fallthrough pseudo-keyword
@ 2020-10-02 22:48 Gustavo A. R. Silva
  2020-10-02 23:52 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2020-10-02 22:48 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz, Jens Axboe
  Cc: linux-ide, linux-kernel, Gustavo A. R. Silva, linux-hardening

Replace /* FALL THRU */ comment with the new pseudo-keyword macro
fallthrough[1].

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/ata/pata_cmd64x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_cmd64x.c b/drivers/ata/pata_cmd64x.c
index 3134eaec9e3d..1d74d89b5bed 100644
--- a/drivers/ata/pata_cmd64x.c
+++ b/drivers/ata/pata_cmd64x.c
@@ -461,7 +461,7 @@ static int cmd64x_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
 		case 1:
 			ppi[0] = &cmd_info[4];
 			ppi[1] = &cmd_info[4];
-			/* FALL THRU */
+			fallthrough;
 		/* Early revs have no CNTRL_CH0 */
 		case 2:
 		case 0:
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] pata_cmd64x: Use fallthrough pseudo-keyword
  2020-10-02 22:48 [PATCH][next] pata_cmd64x: Use fallthrough pseudo-keyword Gustavo A. R. Silva
@ 2020-10-02 23:52 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-10-02 23:52 UTC (permalink / raw)
  To: Gustavo A. R. Silva, Bartlomiej Zolnierkiewicz
  Cc: linux-ide, linux-kernel, linux-hardening

On 10/2/20 4:48 PM, Gustavo A. R. Silva wrote:
> Replace /* FALL THRU */ comment with the new pseudo-keyword macro
> fallthrough[1].
> 
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Applied, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-02 23:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 22:48 [PATCH][next] pata_cmd64x: Use fallthrough pseudo-keyword Gustavo A. R. Silva
2020-10-02 23:52 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).