* [PATCH] libata: libahci: declare ahci_shost_attr_group as static
@ 2021-11-11 3:34 Damien Le Moal
2021-11-11 7:16 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Damien Le Moal @ 2021-11-11 3:34 UTC (permalink / raw)
To: linux-ide; +Cc: linux-scsi, Martin K . Petersen, Bart Van Assche
ahci_shost_attr_group is referenced only in drivers/ata/libahci.c.
Declare it as static.
Fixes: c3f69c7f629f ("scsi: ata: Switch to attribute groups")
Cc: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---
drivers/ata/libahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
index 28430c093a7f..8a6835bfd18a 100644
--- a/drivers/ata/libahci.c
+++ b/drivers/ata/libahci.c
@@ -131,7 +131,7 @@ const struct attribute_group *ahci_shost_groups[] = {
};
EXPORT_SYMBOL_GPL(ahci_shost_groups);
-struct attribute *ahci_sdev_attrs[] = {
+static struct attribute *ahci_sdev_attrs[] = {
&dev_attr_sw_activity.attr,
&dev_attr_unload_heads.attr,
&dev_attr_ncq_prio_supported.attr,
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libata: libahci: declare ahci_shost_attr_group as static
2021-11-11 3:34 [PATCH] libata: libahci: declare ahci_shost_attr_group as static Damien Le Moal
@ 2021-11-11 7:16 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2021-11-11 7:16 UTC (permalink / raw)
To: Damien Le Moal
Cc: linux-ide, linux-scsi, Martin K . Petersen, Bart Van Assche
On Thu, Nov 11, 2021 at 12:34:30PM +0900, Damien Le Moal wrote:
> ahci_shost_attr_group is referenced only in drivers/ata/libahci.c.
> Declare it as static.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-11 7:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 3:34 [PATCH] libata: libahci: declare ahci_shost_attr_group as static Damien Le Moal
2021-11-11 7:16 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).