linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Brian King <brking@linux.vnet.ibm.com>,
	Hannes Reinecke <hare@suse.de>,
	Damien Le Moal <damien.lemoal@opensource.wdc.com>,
	Brian King <brking@us.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: Do we still need the scsi IPR driver ?
Date: Fri, 10 Mar 2023 09:56:35 +0000	[thread overview]
Message-ID: <afaf9f0e-b29d-123b-68f0-38e4a741e07d@oracle.com> (raw)
In-Reply-To: <b7c0f38b-b56f-761b-9ce7-7b3d67a564d0@linux.vnet.ibm.com>

On 13/10/2022 04:36, Brian King wrote:
>>> I've made some progress. I was able to dig up the code to move ipr to use error_handler
>>> and have gotten it to compile, but haven't gotten to trying it in the lab yet.
>>>
>> Hmm. In which machines can I find an IPR installed? I could go hunting in our lab, maybe I can locate one and aid testing/development ...
> Any Power 9 or older generation PowerVM based system would have an IPR installed as the boot device.
> Additionally, on Power 10 systems, ipr SAS controllers are available as an add in card.
> 
> However, the SATA support in ipr was only used to attach the onboard SATA DVD. Power 8 systems were
> the last generation of systems that had an onboard SATA DVD. So, to do any testing with a
> SATA DVD, you'd need a Power 8 or older system.
> 
> Right now I have a patch that removes the SATA support from ipr completely and a patch that changes
> to use the error_handler libata support. The one that changes to use the error_handler libata API
> adds a bit of complexity for a function that should have few or no users that would need this support
> on a current upstream kernel, since only Power 8 and older systems use this support. I'm getting
> a system setup to try out both patches, but at this point I'm leaning towards the patch that
> removes the libata dependency from ipr.

Hi Brian,

I was just wondering did you ever get to test these patches you mention? 
Or any other update on this topic?

Thanks,
John

  reply	other threads:[~2023-03-10  9:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-20  4:48 Do we still need the scsi IPR driver ? Damien Le Moal
2022-06-20  7:35 ` Hannes Reinecke
2022-06-21 20:36 ` Brian King
2022-06-21 20:52   ` Brian King
2022-06-21 22:12     ` Damien Le Moal
2022-09-20 13:07       ` John Garry
2022-10-05 17:20         ` Brian King
2022-10-05 21:21           ` Damien Le Moal
2022-10-06  7:35           ` Hannes Reinecke
2022-10-13  3:36             ` Brian King
2023-03-10  9:56               ` John Garry [this message]
2023-03-13 23:43                 ` Brian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afaf9f0e-b29d-123b-68f0-38e4a741e07d@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=brking@us.ibm.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hare@suse.de \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).