From: Brian King <brking@linux.vnet.ibm.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Brian King <brking@us.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: Do we still need the scsi IPR driver ?
Date: Tue, 21 Jun 2022 15:52:19 -0500 [thread overview]
Message-ID: <be79092f-fdd6-9f0f-4ffa-95ffc4b778c5@linux.vnet.ibm.com> (raw)
In-Reply-To: <3dbd9ae4-a101-e55d-79c8-9b3a96ab5b17@linux.vnet.ibm.com>
On 6/21/22 3:36 PM, Brian King wrote:
> On 6/19/22 11:48 PM, Damien Le Moal wrote:
>>
>> Polling people here: Do we still need the scsi IPR driver for IBM Power
>> Linux RAID adapters (IBM iSeries: 5702, 5703, 2780, 5709, 570A, 570B
>> adapters) ?
>>
>> The reason I am asking is because this driver is the *only* libsas/ata
>> driver that does not define a ->error_handler port operation. If this
>> driver is removed, or if it is modified to use a ->error_handler operation
>> to handle failed commands, then a lot of code simplification can be done
>> in libata, which I am trying to do to facilitate the processing of some
>> special error completion for commands using a command duration limit.
>
> We still need it around for now. IBM still sells these adapters
> and they can still be ordered even on our latest Power 10 systems.
At one point I did look into modifying ipr to use an ->error_handler.
I recall I ran into some issues that resulted in this getting put
on the shelf, but its been a while. I'll go dig that code up and
see what it looks like.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2022-06-21 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 4:48 Do we still need the scsi IPR driver ? Damien Le Moal
2022-06-20 7:35 ` Hannes Reinecke
2022-06-21 20:36 ` Brian King
2022-06-21 20:52 ` Brian King [this message]
2022-06-21 22:12 ` Damien Le Moal
2022-09-20 13:07 ` John Garry
2022-10-05 17:20 ` Brian King
2022-10-05 21:21 ` Damien Le Moal
2022-10-06 7:35 ` Hannes Reinecke
2022-10-13 3:36 ` Brian King
2023-03-10 9:56 ` John Garry
2023-03-13 23:43 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be79092f-fdd6-9f0f-4ffa-95ffc4b778c5@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=brking@us.ibm.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).