* [PATCH v1] Follow up patch to Tegra186 AHCI support patch series
@ 2021-04-08 16:40 Sowjanya Komatineni
2021-04-08 16:40 ` [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
0 siblings, 1 reply; 4+ messages in thread
From: Sowjanya Komatineni @ 2021-04-08 16:40 UTC (permalink / raw)
To: skomatineni, axboe, thierry.reding, digetx
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
This includes a follow up patch to Tegra186 AHCI support patch series
https://lore.kernel.org/patchwork/cover/1408752/
Sowjanya Komatineni (1):
ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is
not present
drivers/ata/ahci_tegra.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 16:40 [PATCH v1] Follow up patch to Tegra186 AHCI support patch series Sowjanya Komatineni
@ 2021-04-08 16:40 ` Sowjanya Komatineni
2021-04-08 19:58 ` Dmitry Osipenko
0 siblings, 1 reply; 4+ messages in thread
From: Sowjanya Komatineni @ 2021-04-08 16:40 UTC (permalink / raw)
To: skomatineni, axboe, thierry.reding, digetx
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
This patch adds a check on present of PM domain and calls legacy power
domain API tegra_powergate_power_off() only when PM domain is not present.
This is a follow-up patch to Tegra186 AHCI support patch series
https://lore.kernel.org/patchwork/cover/1408752/
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/ata/ahci_tegra.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
index 56612af..bd484dd 100644
--- a/drivers/ata/ahci_tegra.c
+++ b/drivers/ata/ahci_tegra.c
@@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
reset_control_assert(tegra->sata_cold_rst);
clk_disable_unprepare(tegra->sata_clk);
- tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
+ if (!tegra->pdev->dev.pm_domain)
+ tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 16:40 ` [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
@ 2021-04-08 19:58 ` Dmitry Osipenko
2021-04-08 20:49 ` Sowjanya Komatineni
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Osipenko @ 2021-04-08 19:58 UTC (permalink / raw)
To: Sowjanya Komatineni, axboe, thierry.reding
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
08.04.2021 19:40, Sowjanya Komatineni пишет:
> This patch adds a check on present of PM domain and calls legacy power
> domain API tegra_powergate_power_off() only when PM domain is not present.
>
> This is a follow-up patch to Tegra186 AHCI support patch series
> https://lore.kernel.org/patchwork/cover/1408752/
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>
> ---
> drivers/ata/ahci_tegra.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
> index 56612af..bd484dd 100644
> --- a/drivers/ata/ahci_tegra.c
> +++ b/drivers/ata/ahci_tegra.c
> @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
> reset_control_assert(tegra->sata_cold_rst);
>
> clk_disable_unprepare(tegra->sata_clk);
> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
> + if (!tegra->pdev->dev.pm_domain)
> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>
> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> }
>
There are two instances of tegra_powergate_power_off() in the driver.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present
2021-04-08 19:58 ` Dmitry Osipenko
@ 2021-04-08 20:49 ` Sowjanya Komatineni
0 siblings, 0 replies; 4+ messages in thread
From: Sowjanya Komatineni @ 2021-04-08 20:49 UTC (permalink / raw)
To: Dmitry Osipenko, axboe, thierry.reding
Cc: jonathanh, linux-ide, linux-tegra, linux-kernel
On 4/8/21 12:58 PM, Dmitry Osipenko wrote:
> 08.04.2021 19:40, Sowjanya Komatineni пишет:
>> This patch adds a check on present of PM domain and calls legacy power
>> domain API tegra_powergate_power_off() only when PM domain is not present.
>>
>> This is a follow-up patch to Tegra186 AHCI support patch series
>> https://lore.kernel.org/patchwork/cover/1408752/
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>
>> ---
>> drivers/ata/ahci_tegra.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/ahci_tegra.c b/drivers/ata/ahci_tegra.c
>> index 56612af..bd484dd 100644
>> --- a/drivers/ata/ahci_tegra.c
>> +++ b/drivers/ata/ahci_tegra.c
>> @@ -287,7 +287,8 @@ static void tegra_ahci_power_off(struct ahci_host_priv *hpriv)
>> reset_control_assert(tegra->sata_cold_rst);
>>
>> clk_disable_unprepare(tegra->sata_clk);
>> - tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>> + if (!tegra->pdev->dev.pm_domain)
>> + tegra_powergate_power_off(TEGRA_POWERGATE_SATA);
>>
>> regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
>> }
>>
> There are two instances of tegra_powergate_power_off() in the driver.
Thanks Dmitry. Sorry missed it. Will fix
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-08 20:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 16:40 [PATCH v1] Follow up patch to Tegra186 AHCI support patch series Sowjanya Komatineni
2021-04-08 16:40 ` [PATCH v1] ata: ahci_tegra: call tegra_powergate_power_off only when PM domain is not present Sowjanya Komatineni
2021-04-08 19:58 ` Dmitry Osipenko
2021-04-08 20:49 ` Sowjanya Komatineni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).