From: Jens Axboe <firstname.lastname@example.org> To: Hans de Goede <email@example.com>, Kate Hsuan <firstname.lastname@example.org>, Damien Le Moal <email@example.com> Cc: firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v6] libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD. Date: Fri, 3 Sep 2021 08:05:54 -0600 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 9/3/21 8:03 AM, Hans de Goede wrote: > Hi, > > On 9/3/21 2:35 PM, Jens Axboe wrote: >> On 9/3/21 3:44 AM, Kate Hsuan wrote: >>> Many users are reporting that the Samsung 860 and 870 SSD are having >>> various issues when combined with AMD/ATI (vendor ID 0x1002) SATA >>> controllers and only completely disabling NCQ helps to avoid these >>> issues. >>> >>> Always disabling NCQ for Samsung 860/870 SSDs regardless of the host >>> SATA adapter vendor will cause I/O performance degradation with well >>> behaved adapters. To limit the performance impact to ATI adapters, >>> introduce the ATA_HORKAGE_NO_NCQ_ON_ATI flag to force disable NCQ >>> only for these adapters. >>> >>> Also, two libata.force parameters (noncqati and ncqati) are introduced >>> to disable and enable the NCQ for the system which equipped with ATI >>> SATA adapter and Samsung 860 and 870 SSDs. The user can determine NCQ >>> function to be enabled or disabled according to the demand. >>> >>> After verifying the chipset from the user reports, the issue appears >>> on AMD/ATI SB7x0/SB8x0/SB9x0 SATA Controllers and does not appear on >>> recent AMD SATA adapters. The vendor ID of ATI should be 0x1002. >>> Therefore, ATA_HORKAGE_NO_NCQ_ON_AMD was modified to >>> ATA_HORKAGE_NO_NCQ_ON_ATI. >> >> What's this patch against? > > linux-block/for-next + my pre-cursor patch from here: > > https://firstname.lastname@example.org/T/#u Still had to fixup a hunk, but it was trivial. In any case, I've applied both now, thanks! -- Jens Axboe
next prev parent reply other threads:[~2021-09-03 14:05 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-03 9:44 Kate Hsuan 2021-09-03 10:03 ` Hans de Goede 2021-09-03 12:35 ` Jens Axboe 2021-09-03 14:03 ` Hans de Goede 2021-09-03 14:05 ` Jens Axboe [this message] 2021-09-03 13:08 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v6] libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).