* [PATCH] Add AHCI support for ASM1062+JBM575 cards
@ 2021-10-11 11:48 István Pongrácz
2021-10-11 19:55 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: István Pongrácz @ 2021-10-11 11:48 UTC (permalink / raw)
To: linux-ide, damien.lemoal; +Cc: István Pongrácz
Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
---
drivers/ata/ahci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 186cbf90c8ea..97fd96b67731 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci }, /* ASM1061R */
{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci }, /* ASM1062R */
+ { PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, /* ASM1062+JMB575 */
/*
* Samsung SSDs found on some macbooks. NCQ times out if MSI is
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Add AHCI support for ASM1062+JBM575 cards
2021-10-11 11:48 [PATCH] Add AHCI support for ASM1062+JBM575 cards István Pongrácz
@ 2021-10-11 19:55 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-10-11 19:55 UTC (permalink / raw)
To: István Pongrácz, linux-ide
On 2021/10/11 20:48, István Pongrácz wrote:
> Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
Getting there ! But you forgot to add a short commit message. You do not need
much I think: simply describe the hardware being supported. I think this is a
SATA expander card with port multiplier, right ?
So something like:
Add support for SATA expander card based on ASMedia blah controller chip.
Will be fine.
> ---
> drivers/ata/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ea..97fd96b67731 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
> { PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
> { PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci }, /* ASM1061R */
> { PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci }, /* ASM1062R */
> + { PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, /* ASM1062+JMB575 */
>
> /*
> * Samsung SSDs found on some macbooks. NCQ times out if MSI is
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Add AHCI support for ASM1062+JBM575 cards
@ 2021-10-11 20:36 István Pongrácz
2021-10-11 20:44 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: István Pongrácz @ 2021-10-11 20:36 UTC (permalink / raw)
To: linux-ide, damien.lemoal; +Cc: István Pongrácz
Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
Add support for PCIe SATA expander cards based on ASMedia 1062 + JBM575
controllers.
These cards could provide up to 10 or more SATA ports on one PCIe card.
---
drivers/ata/ahci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index 186cbf90c8ea..97fd96b67731 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
{ PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
{ PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci }, /* ASM1061R */
{ PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci }, /* ASM1062R */
+ { PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, /* ASM1062+JMB575 */
/*
* Samsung SSDs found on some macbooks. NCQ times out if MSI is
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Add AHCI support for ASM1062+JBM575 cards
2021-10-11 20:36 István Pongrácz
@ 2021-10-11 20:44 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2021-10-11 20:44 UTC (permalink / raw)
To: István Pongrácz, linux-ide
On 2021/10/12 5:36, István Pongrácz wrote:
> Signed-off-by: István Pongrácz <pongracz.istvan@gmail.com>
This must be at the end of the patch (commit message comes first).
>
> Add support for PCIe SATA expander cards based on ASMedia 1062 + JBM575
> controllers.
> These cards could provide up to 10 or more SATA ports on one PCIe card.
s/could/can
Also, FYI, when you resend new versions of a patch, please add a version number
in the patch title with [PATCH v2]. And add a changelog after the "---" below.
Something like: "Changes from v1: blah". This changelog is automatically dropped
when the patch is applied. It is only useful to facilitate reviews.
> ---
> drivers/ata/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ea..97fd96b67731 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -592,6 +592,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
> { PCI_VDEVICE(ASMEDIA, 0x0612), board_ahci }, /* ASM1062 */
> { PCI_VDEVICE(ASMEDIA, 0x0621), board_ahci }, /* ASM1061R */
> { PCI_VDEVICE(ASMEDIA, 0x0622), board_ahci }, /* ASM1062R */
> + { PCI_VDEVICE(ASMEDIA, 0x0624), board_ahci }, /* ASM1062+JMB575 */
>
> /*
> * Samsung SSDs found on some macbooks. NCQ times out if MSI is
>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-11 20:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 11:48 [PATCH] Add AHCI support for ASM1062+JBM575 cards István Pongrácz
2021-10-11 19:55 ` Damien Le Moal
2021-10-11 20:36 István Pongrácz
2021-10-11 20:44 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).