From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: jic23@kernel.org, linux-iio@vger.kernel.org
Cc: srinivas.pandruvada@linux.intel.com, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, laurentiu.palcu@intel.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] iio: accel: BMC150: fix issues when CONFIG_PM_RUNTIME is not set
Date: Thu, 28 Aug 2014 11:35:05 +0300 [thread overview]
Message-ID: <1409214906-27038-3-git-send-email-laurentiu.palcu@intel.com> (raw)
In-Reply-To: <1409214906-27038-1-git-send-email-laurentiu.palcu@intel.com>
When CONFIG_PM_RUNTIME is not set, the following issues are seen:
* warning message at compilation time:
warning: 'bmc150_accel_get_startup_times' defined but not used [-Wunused-function]
* bmc150_accel_set_power_state() will always fail and reading the
accelerometer data is impossible;
This commit fixes these.
Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
---
drivers/iio/accel/bmc150-accel.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/accel/bmc150-accel.c b/drivers/iio/accel/bmc150-accel.c
index ccb6cf8..0e6566a 100644
--- a/drivers/iio/accel/bmc150-accel.c
+++ b/drivers/iio/accel/bmc150-accel.c
@@ -499,6 +499,7 @@ static int bmc150_accel_get_bw(struct bmc150_accel_data *data, int *val,
return -EINVAL;
}
+#ifdef CONFIG_PM_RUNTIME
static int bmc150_accel_get_startup_times(struct bmc150_accel_data *data)
{
int i;
@@ -529,6 +530,12 @@ static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
return 0;
}
+#else
+static int bmc150_accel_set_power_state(struct bmc150_accel_data *data, bool on)
+{
+ return 0;
+}
+#endif
static int bmc150_accel_set_scale(struct bmc150_accel_data *data, int val)
{
--
1.9.1
next prev parent reply other threads:[~2014-08-28 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:35 [PATCH 0/3] iio: accel: BMC150: add support for more Bosch chips Laurentiu Palcu
2014-08-28 8:35 ` [PATCH 1/3] iio: accel: BMC150: fix scale value for 16G Laurentiu Palcu
2014-08-28 8:35 ` Laurentiu Palcu [this message]
2014-08-28 8:35 ` [PATCH 3/3] iio: accel: BMC150: add support for other Bosch chips Laurentiu Palcu
2014-08-28 9:21 ` Laurentiu Palcu
2014-08-28 9:26 ` Peter Meerwald
2014-08-28 10:46 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409214906-27038-3-git-send-email-laurentiu.palcu@intel.com \
--to=laurentiu.palcu@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).