From: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "lars@metafoo.de" <lars@metafoo.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v5 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL
Date: Wed, 12 Jun 2019 14:09:47 +0000 [thread overview]
Message-ID: <1560348586.4768.5.camel@analog.com> (raw)
In-Reply-To: <20190611215932.GA24974@bogus>
Hi Rob,
I'm sorry I forgot to include your Reviewed-by in this patch series.
However, I realized this mistake and added it to v6 which in the meantime
Jonathan has applied.
I will fix your remark bellow regarding clock-names in the next patch
series for this device.
Thank you,
-Stefan
On Ma, 2019-06-11 at 15:59 -0600, Rob Herring wrote:
>
>
> On Tue, Jun 04, 2019 at 04:08:17PM +0300, Stefan Popa wrote:
> >
> > Document support for Analog Devices ADF4371 SPI Wideband Synthesizer.
> >
> > Signed-off-by: Stefan Popa <stefan.popa@analog.com>
> > ---
> > Changes in v2:
> > - Nothing changed.
> > Changes in v3:
> > - Nothing changed.
> > Changes in v4:
> > - Nothing changed.
> > Changes in v5:
> > - Nothing changed.
> Please add acks/reviewed-bys when posting new versions.
>
> But something else I noticed:
>
> >
> >
> > .../devicetree/bindings/iio/frequency/adf4371.yaml | 54
> > ++++++++++++++++++++++
> > 1 file changed, 54 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > new file mode 100644
> > index 0000000..d7adf074
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/frequency/adf4371.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices ADF4371 Wideband Synthesizer
> > +
> > +maintainers:
> > + - Popa Stefan <stefan.popa@analog.com>
> > +
> > +description: |
> > + Analog Devices ADF4371 SPI Wideband Synthesizer
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/
> > adf4371.pdf
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,adf4371
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + description:
> > + Definition of the external clock (see clock/clock-bindings.txt)
> > + maxItems: 1
> > +
> > + clock-names:
> > + description:
> > + Must be "clkin"
> This can be a schema:
>
> clock-names:
> items:
> - clkin
>
> >
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
> > +
> > +examples:
> > + - |
> > + spi0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + frequency@0 {
> > + compatible = "adi,adf4371";
> > + reg = <0>;
> > + spi-max-frequency = <1000000>;
> > + clocks = <&adf4371_clkin>;
> > + clock-names = "clkin";
> > + };
> > + };
> > +...
> > --
> > 2.7.4
> >
prev parent reply other threads:[~2019-06-12 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 13:08 [PATCH v5 2/2] dt-bindings: iio: frequency: Add docs for ADF4371 PLL Stefan Popa
2019-06-11 21:59 ` Rob Herring
2019-06-11 22:00 ` Rob Herring
2019-06-12 14:09 ` Popa, Stefan Serban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560348586.4768.5.camel@analog.com \
--to=stefanserban.popa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).