From: Jonathan Cameron <jic23@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: mma8452: Mark expected switch fall-through
Date: Sat, 7 Jul 2018 18:04:35 +0100 [thread overview]
Message-ID: <20180707180435.414b7a95@archlinux> (raw)
In-Reply-To: <20180703194436.GA15537@embeddedor.com>
On Tue, 3 Jul 2018 14:44:36 -0500
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Warning level 2 was used in this case: -Wimplicit-fallthrough=2
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to ignore.
Thanks,
Jonathan
> ---
> drivers/iio/accel/mma8452.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index c149c9c..421a0a8 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -1547,6 +1547,7 @@ static int mma8452_probe(struct i2c_client *client,
> case FXLS8471_DEVICE_ID:
> if (ret == data->chip_info->chip_id)
> break;
> + /* else: fall through */
> default:
> return -ENODEV;
> }
next prev parent reply other threads:[~2018-07-07 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 19:44 [PATCH] iio: mma8452: Mark expected switch fall-through Gustavo A. R. Silva
2018-07-07 17:04 ` Jonathan Cameron [this message]
2019-02-11 22:23 [PATCH] iio: mma8452: mark " Gustavo A. R. Silva
2019-02-20 12:17 ` Jonathan Cameron
2019-02-20 17:21 ` Gustavo A. R. Silva
2019-02-20 18:07 ` Gustavo A. R. Silva
2019-03-03 17:04 ` Jonathan Cameron
2019-03-03 17:35 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707180435.414b7a95@archlinux \
--to=jic23@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).