From: Jonathan Cameron <jic23@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>
Subject: Re: [PATCH v3 3/3] iio: ti-ads8688: Update buffer allocation for timestamps
Date: Sat, 12 Jan 2019 18:33:38 +0000 [thread overview]
Message-ID: <20190112183338.59076438@archlinux> (raw)
In-Reply-To: <20190111195707.2086-3-dmurphy@ti.com>
On Fri, 11 Jan 2019 13:57:07 -0600
Dan Murphy <dmurphy@ti.com> wrote:
> Per Jonathan Cameron, the buffer needs to allocate room for a
> 64 bit timestamp as well as the channels. Change the buffer
> to allocate this additional space.
>
> Fixes: 2a86487786b5c ("iio: adc: ti-ads8688: add trigger and buffer support")
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks for fixing this up!
Jonathan
> ---
>
> v3 - Updated the buffer allocation definition I also dropped the device managed
> patch as I don't have time to invest in that code - https://lore.kernel.org/patchwork/patch/1023971/
> v2 - New patch suggested change by maintainer - https://lore.kernel.org/patchwork/patch/1021048/
>
> drivers/iio/adc/ti-ads8688.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti-ads8688.c b/drivers/iio/adc/ti-ads8688.c
> index 184d686ebd99..8b4568edd5cb 100644
> --- a/drivers/iio/adc/ti-ads8688.c
> +++ b/drivers/iio/adc/ti-ads8688.c
> @@ -41,6 +41,7 @@
>
> #define ADS8688_VREF_MV 4096
> #define ADS8688_REALBITS 16
> +#define ADS8688_MAX_CHANNELS 8
>
> /*
> * enum ads8688_range - ADS8688 reference voltage range
> @@ -385,7 +386,7 @@ static irqreturn_t ads8688_trigger_handler(int irq, void *p)
> {
> struct iio_poll_func *pf = p;
> struct iio_dev *indio_dev = pf->indio_dev;
> - u16 buffer[8];
> + u16 buffer[ADS8688_MAX_CHANNELS + sizeof(s64)/sizeof(u16)];
> int i, j = 0;
>
> for (i = 0; i < indio_dev->masklength; i++) {
next prev parent reply other threads:[~2019-01-12 18:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 19:57 [PATCH v3 1/3] iio: ti-ads124s08: Add DT binding documentation Dan Murphy
2019-01-11 19:57 ` [PATCH v3 2/3] iio: adc: Add the TI ads124s08 ADC code Dan Murphy
2019-01-12 18:42 ` Jonathan Cameron
2019-01-12 18:43 ` Jonathan Cameron
2019-01-14 21:31 ` Dan Murphy
2019-01-19 16:55 ` Jonathan Cameron
2019-01-11 19:57 ` [PATCH v3 3/3] iio: ti-ads8688: Update buffer allocation for timestamps Dan Murphy
2019-01-12 18:33 ` Jonathan Cameron [this message]
2019-01-12 18:40 ` [PATCH v3 1/3] iio: ti-ads124s08: Add DT binding documentation Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190112183338.59076438@archlinux \
--to=jic23@kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).