From: Tomasz Duszynski <tduszyns@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: Tomasz Duszynski <tduszyns@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org,
jic23@jic23.retrosnub.co.uk
Subject: Re: [PATCH v2 3/3] dt-bindings: iio: chemical: pms7003: add device tree support
Date: Mon, 28 Jan 2019 19:43:33 +0100 [thread overview]
Message-ID: <20190128184332.GA25627@arch> (raw)
In-Reply-To: <20190128075819.GK3691@localhost>
On Mon, Jan 28, 2019 at 08:58:19AM +0100, Johan Hovold wrote:
> On Sun, Jan 27, 2019 at 07:19:16PM +0100, Tomasz Duszynski wrote:
> > Add device tree support for Plantower PMS7003 particulate matter sensor.
> >
> > Signed-off-by: Tomasz Duszynski <tduszyns@gmail.com>
> > ---
> > .../iio/chemical/plantower,pms7003.txt | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> >
> > diff --git a/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> > new file mode 100644
> > index 000000000000..e4c7f2fb1e30
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/chemical/plantower,pms7003.txt
> > @@ -0,0 +1,19 @@
> > +* Plantower PMS7003 particulate matter sensor
> > +
> > +Required properties:
> > +- compatible: must be "plantower,pms7003"
> > +
> > +Optional properties:
> > +- vcc-supply: phandle to the regulator that provides power to the sensor
>
> Shouldn't this one be a required property?
>
Driver does not use regulator framework hence to me this property fits
here better.
> > +- set-gpios: phandle to the GPIO connected to the SET line
> > +- reset-gpios: phandle to the GPIO connected to the RESET line
> > +
> > +Refer to serial/slave-device.txt for generic serial attached device bindings.
> > +
> > +Example:
> > +
> > +&uart0 {
> > + pms7003 {
>
> The node name should be generic and reflect the functionality rather
> than model. Perhaps "pms" will do here.
>
Agree, ideally we should have a generic dt name for this kind of sensors
(something like air-pollution-sensor perhaps?). But unfortunately there isn't
anything available now so I guess compatible part name should be okay
(besides this is the type of naming commonly used in other iio bindings).
> > + compatible = "plantower,pms7003";
> > + };
> > +};
>
> Johan
next prev parent reply other threads:[~2019-01-28 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 18:19 [PATCH v2 0/3] add support for PMS7003 PM sensor Tomasz Duszynski
2019-01-27 18:19 ` [PATCH v2 1/3] iio: chemical: add support for Plantower PMS7003 sensor Tomasz Duszynski
2019-01-27 18:53 ` Peter Meerwald-Stadler
2019-01-27 21:06 ` Tomasz Duszynski
2019-01-27 18:19 ` [PATCH v2 2/3] dt-bindings: add Plantower to the vendor prefixes Tomasz Duszynski
2019-01-27 18:19 ` [PATCH v2 3/3] dt-bindings: iio: chemical: pms7003: add device tree support Tomasz Duszynski
2019-01-28 7:58 ` Johan Hovold
2019-01-28 18:43 ` Tomasz Duszynski [this message]
2019-01-30 9:12 ` Johan Hovold
2019-01-31 20:40 ` Tomasz Duszynski
2019-02-01 9:12 ` Johan Hovold
2019-02-01 17:10 ` Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190128184332.GA25627@arch \
--to=tduszyns@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=johan@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).