From: Renato Lui Geh <renatogeh@gmail.com>
To: "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>
Cc: "renatogeh@gmail.com" <renatogeh@gmail.com>,
"kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"giuliano.belinassi@usp.br" <giuliano.belinassi@usp.br>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support
Date: Fri, 1 Feb 2019 15:55:16 -0200 [thread overview]
Message-ID: <20190201175514.7kerqvuln4mrhinp@renatolg> (raw)
In-Reply-To: <1549036667.9460.41.camel@analog.com>
On 02/01, Popa, Stefan Serban wrote:
>
>Adding support for gpios, normally doesn't have anything to do with
>the information stored in the iio_chan_spec struct.
>Also, we need to try to work with the already defined attributes. In your
>case, setting the gain GPIO is equivalent to modifying the scale, while
>setting the filter GPIO results in a change in sampling frequency.
>Therefore, we need use a macro which has the IIO_CHAN_INFO_SCALE and
>IIO_CHAN_INFO_FREQUENCY flags set. I think AD_SD_CHANNEL should do just
>fine.
>I hope this answers your question.
>-Stefan
It does. Thank you. :)
prev parent reply other threads:[~2019-02-01 17:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 20:30 [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio support Renato Lui Geh
2019-01-30 12:23 ` Popa, Stefan Serban
2019-02-01 14:55 ` Renato Lui Geh
2019-02-01 15:57 ` Popa, Stefan Serban
2019-02-01 17:55 ` Renato Lui Geh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190201175514.7kerqvuln4mrhinp@renatolg \
--to=renatogeh@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=giuliano.belinassi@usp.br \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).