From: Tomasz Duszynski <tduszyns@gmail.com>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: jic23@kernel.org, thierry.reding@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, alexandre.torgue@st.com,
mcoquelin.stm32@gmail.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
vilhelm.gray@gmail.com, linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 2/4] pwm: stm32-lp: Add power management support
Date: Tue, 5 Feb 2019 19:30:09 +0100 [thread overview]
Message-ID: <20190205183005.GA13960@arch> (raw)
In-Reply-To: <1549370429-19116-3-git-send-email-fabrice.gasnier@st.com>
On Tue, Feb 05, 2019 at 01:40:27PM +0100, Fabrice Gasnier wrote:
> Add suspend/resume PM sleep ops. When going to low power, disable
> active PWM channel. Active PWM channel is resumed, by calling
> pwm_apply_state(). This is inspired by Thierry's comment in [1].
> Don't touch inactive channels, as it may be used by other LPTimer MFD
> child driver.
> [1]https://lkml.org/lkml/2017/12/5/175
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> drivers/pwm/pwm-stm32-lp.c | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c
> index 0059b24c..0c40d48 100644
> --- a/drivers/pwm/pwm-stm32-lp.c
> +++ b/drivers/pwm/pwm-stm32-lp.c
> @@ -13,6 +13,7 @@
> #include <linux/mfd/stm32-lptimer.h>
> #include <linux/module.h>
> #include <linux/of.h>
> +#include <linux/pinctrl/consumer.h>
> #include <linux/platform_device.h>
> #include <linux/pwm.h>
>
> @@ -20,6 +21,8 @@ struct stm32_pwm_lp {
> struct pwm_chip chip;
> struct clk *clk;
> struct regmap *regmap;
> + struct pwm_state suspend;
> + bool suspended;
> };
>
> static inline struct stm32_pwm_lp *to_stm32_pwm_lp(struct pwm_chip *chip)
> @@ -223,6 +226,40 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev)
> return pwmchip_remove(&priv->chip);
> }
>
> +#ifdef CONFIG_PM_SLEEP
You might consider dropping ifdefs and marking pm functions with
__maybe_unused instead. In case CONFIG_PM_SLEEP=n then these two guys
will be removed and pm ops structure will be empty.
> +static int stm32_pwm_lp_suspend(struct device *dev)
> +{
> + struct stm32_pwm_lp *priv = dev_get_drvdata(dev);
> +
I guess you first need to get platform_device from dev and eventually
stm32_pwm_lp. Wondering how this works now.
> + pwm_get_state(&priv->chip.pwms[0], &priv->suspend);
> + priv->suspended = priv->suspend.enabled;
> +
> + /* safe to call pwm_disable() for already disabled pwm */
> + pwm_disable(&priv->chip.pwms[0]);
> +
> + return pinctrl_pm_select_sleep_state(dev);
> +}
> +
> +static int stm32_pwm_lp_resume(struct device *dev)
> +{
> + struct stm32_pwm_lp *priv = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = pinctrl_pm_select_default_state(dev);
> + if (ret)
> + return ret;
> +
> + /* Only restore suspended pwm, not to disrupt other MFD child */
> + if (!priv->suspended)
> + return 0;
Would it make sense to use suspend.enabled directly?
> +
> + return pwm_apply_state(&priv->chip.pwms[0], &priv->suspend);
> +}
> +#endif
> +
> +static SIMPLE_DEV_PM_OPS(stm32_pwm_lp_pm_ops, stm32_pwm_lp_suspend,
> + stm32_pwm_lp_resume);
> +
> static const struct of_device_id stm32_pwm_lp_of_match[] = {
> { .compatible = "st,stm32-pwm-lp", },
> {},
> @@ -235,6 +272,7 @@ static int stm32_pwm_lp_remove(struct platform_device *pdev)
> .driver = {
> .name = "stm32-pwm-lp",
> .of_match_table = of_match_ptr(stm32_pwm_lp_of_match),
> + .pm = &stm32_pwm_lp_pm_ops,
> },
> };
> module_platform_driver(stm32_pwm_lp_driver);
> --
> 1.9.1
>
next prev parent reply other threads:[~2019-02-05 18:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 12:40 [PATCH 0/4] Add PM support to STM32 LP Timer drivers Fabrice Gasnier
2019-02-05 12:40 ` [PATCH 1/4] dt-bindings: pwm-stm32-lp: document pinctrl sleep state Fabrice Gasnier
2019-02-05 12:40 ` [PATCH 2/4] pwm: stm32-lp: Add power management support Fabrice Gasnier
2019-02-05 18:30 ` Tomasz Duszynski [this message]
2019-02-06 8:42 ` Fabrice Gasnier
2019-02-05 20:47 ` Uwe Kleine-König
2019-02-05 22:25 ` Thierry Reding
2019-02-06 8:42 ` Fabrice Gasnier
2019-02-06 8:54 ` Uwe Kleine-König
2019-02-06 12:55 ` Thierry Reding
2019-02-06 14:54 ` Fabrice Gasnier
2019-02-05 12:40 ` [PATCH 3/4] dt-bindings: iio: stm32-lptimer-counter: document pinctrl sleep state Fabrice Gasnier
2019-02-05 12:40 ` [PATCH 4/4] iio: counter: stm32-lptimer: Add power management support Fabrice Gasnier
2019-02-09 16:21 ` Jonathan Cameron
2019-02-10 21:33 ` Uwe Kleine-König
2019-02-11 13:21 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205183005.GA13960@arch \
--to=tduszyns@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).