From: Jonathan Cameron <jic23@kernel.org>
To: Ricardo Ribalda Delgado <ricardo@ribalda.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/2] iio:dac:dac7612: device tree bindings
Date: Sat, 9 Feb 2019 16:03:51 +0000 [thread overview]
Message-ID: <20190209160351.5654f4d1@archlinux> (raw)
In-Reply-To: <20190204124833.18779-2-ricardo@ribalda.com>
On Mon, 4 Feb 2019 13:48:33 +0100
Ricardo Ribalda Delgado <ricardo@ribalda.com> wrote:
> Bindings for dac7612.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Ricardo Ribalda Delgado <ricardo@ribalda.com>
Simple binding so I'm happy to take with out a DT review unless someone
feels like giving one. Seems to have answered Rob's previous comments.
Applied to the togreg branch of iio.git with the tiny tweak of dropping
the extra blank line at the end of the file.
Thanks,
Jonathan
> ---
> v4 Changelog by Rob Herring <robh@kernel.org>
>
> -Add ti, prefix to gpio
> -Fix example da@1
> -Fix partname
>
> .../bindings/iio/dac/ti,dac7612.txt | 29 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
> new file mode 100644
> index 000000000000..14a66c0dcdaa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
> @@ -0,0 +1,29 @@
> +* Texas Instruments Dual, 12-Bit Serial Input Digital-to-Analog Converter
> +
> +The DAC7612 is a dual, 12-bit digital-to-analog converter (DAC) with guaranteed
> +12-bit monotonicity performance over the industrial temperature range.
> +Is is programmable through an SPI interface.
> +
> +The internal DACs are loaded when the LOADDACS pin is pulled down.
> +
> +http://www.ti.com/lit/ds/sbas106/sbas106.pdf
> +
> +Required Properties:
> +- compatible: Should be one of:
> + "ti,dac7612"
> + "ti,dac7612u"
> + "ti,dac7612ub"
> +- reg: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Optional Properties:
> +- ti,loaddacs-gpios: GPIO descriptor for the LOADDACS pin.
> +- spi-*: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +
> + dac@1 {
> + compatible = "ti,dac7612";
> + reg = <0x1>;
> + ti,loaddacs-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>;
> + };
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 30ba5435906b..e28e5afaae16 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14882,6 +14882,7 @@ M: Ricardo Ribalda <ricardo@ribalda.com>
> L: linux-iio@vger.kernel.org
> S: Supported
> F: drivers/iio/dac/ti-dac7612.c
> +F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
>
> THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER
> M: Hans Verkuil <hverkuil@xs4all.nl>
next prev parent reply other threads:[~2019-02-09 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 12:48 [PATCH v4 1/2] iio:dac:ti-dac7612: Add driver for Texas Instruments DAC7612 Ricardo Ribalda Delgado
2019-02-04 12:48 ` [PATCH v4 2/2] iio:dac:dac7612: device tree bindings Ricardo Ribalda Delgado
2019-02-09 16:03 ` Jonathan Cameron [this message]
2019-02-09 16:04 ` [PATCH v4 1/2] iio:dac:ti-dac7612: Add driver for Texas Instruments DAC7612 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209160351.5654f4d1@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo@ribalda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).