From: Jonathan Cameron <jic23@kernel.org>
To: Tomasz Duszynski <tduszyns@gmail.com>
Cc: linux-iio@vger.kernel.org, Andreas Brauchli <a.brauchli@elementarea.net>
Subject: Re: [PATCH] iio:chemical:sps30 Suppress some switch fallthrough warnings.
Date: Mon, 11 Feb 2019 20:08:39 +0000 [thread overview]
Message-ID: <20190211200839.0b625f50@archlinux> (raw)
In-Reply-To: <20190209201209.GA19661@arch>
On Sat, 9 Feb 2019 21:12:10 +0100
Tomasz Duszynski <tduszyns@gmail.com> wrote:
> On Sat, Feb 09, 2019 at 07:39:34PM +0000, Jonathan Cameron wrote:
> > Fixes warnings reported on linux-next but marking one path
> > and adding an explicit return in the other.
> >
>
> Looks good.
>
> Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
Thanks,
Applied to the togreg branch of iio.git.
Jonathan
>
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Andreas Brauchli <a.brauchli@elementarea.net>
> > ---
> > I'd like to get this one into linux-next fairly quick so it anyone
> > has time to do a quick sanity check it would be much appreciated!
> >
> > drivers/iio/chemical/sps30.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c
> > index 375df5060ed5..edbb956e81e8 100644
> > --- a/drivers/iio/chemical/sps30.c
> > +++ b/drivers/iio/chemical/sps30.c
> > @@ -118,6 +118,7 @@ static int sps30_do_cmd(struct sps30_state *state, u16 cmd, u8 *data, int size)
> > case SPS30_READ_AUTO_CLEANING_PERIOD:
> > buf[0] = SPS30_AUTO_CLEANING_PERIOD >> 8;
> > buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
> > + /* fall through */
> > case SPS30_READ_DATA_READY_FLAG:
> > case SPS30_READ_DATA:
> > case SPS30_READ_SERIAL:
> > @@ -295,6 +296,8 @@ static int sps30_read_raw(struct iio_dev *indio_dev,
> > *val2 = 10000;
> >
> > return IIO_VAL_INT_PLUS_MICRO;
> > + default:
> > + return -EINVAL;
> > }
> > default:
> > return -EINVAL;
> > --
> > 2.20.1
> >
prev parent reply other threads:[~2019-02-11 20:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 19:39 [PATCH] iio:chemical:sps30 Suppress some switch fallthrough warnings Jonathan Cameron
2019-02-09 20:12 ` Tomasz Duszynski
2019-02-11 20:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211200839.0b625f50@archlinux \
--to=jic23@kernel.org \
--cc=a.brauchli@elementarea.net \
--cc=linux-iio@vger.kernel.org \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).