From: Jonathan Cameron <jic23@kernel.org>
To: "Angus Ainslie (Purism)" <angus@akkea.ca>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Tomas Novotny <tomas@novotny.cz>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] iio: light: vcnl4000 add devicetree hooks
Date: Sun, 24 Mar 2019 17:19:30 +0000 [thread overview]
Message-ID: <20190324171930.7580e6bb@archlinux> (raw)
In-Reply-To: <20190321154047.23236-3-angus@akkea.ca>
On Thu, 21 Mar 2019 08:40:44 -0700
"Angus Ainslie (Purism)" <angus@akkea.ca> wrote:
> Add an of_match table for devicetree probing.
>
> Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
I made a small tweak (see inline) for an issue I'd missed
previously (which is pretty obscure!)
Jonathan
> ---
> drivers/iio/light/vcnl4000.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
> index 5e0a8eb83ebc..308cb2d2b641 100644
> --- a/drivers/iio/light/vcnl4000.c
> +++ b/drivers/iio/light/vcnl4000.c
> @@ -363,9 +363,31 @@ static int vcnl4000_probe(struct i2c_client *client,
> return devm_iio_device_register(&client->dev, indio_dev);
> }
>
> +static const struct of_device_id vcnl_4000_of_match[] = {
> + {
> + .compatible = "vishay,vcnl4000",
> + .data = "VCNL4000",
> + },
> + {
> + .compatible = "vishay,vcnl4010",
> + .data = "VCNL4010",
> + },
> + {
> + .compatible = "vishay,vcnl4010",
> + .data = "VCNL4020",
> + },
> + {
> + .compatible = "vishay,vcnl4200",
> + .data = "VCNL4200",
> + },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, vcnl4000_of_match);
> +
> static struct i2c_driver vcnl4000_driver = {
> .driver = {
> .name = VCNL4000_DRV_NAME,
> + .of_match_table = of_match_ptr(vcnl_4000_of_match),
Ah. I'd missed this previously. Don't use the of_match_ptr
magic anymore. It prevents ACPI probing via the weird
DSDT entry that basically says "here be devicetree".
> },
> .probe = vcnl4000_probe,
> .id_table = vcnl4000_id,
next prev parent reply other threads:[~2019-03-24 17:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:40 [PATCH v3 0/5] Add a VCNL4040 light and proximity driver Angus Ainslie (Purism)
2019-03-21 15:40 ` [PATCH v3 1/5] iio: light: vcnl4000 use word writes instead of byte writes Angus Ainslie (Purism)
2019-03-24 17:18 ` Jonathan Cameron
2019-03-21 15:40 ` [PATCH v3 2/5] iio: light: vcnl4000 add devicetree hooks Angus Ainslie (Purism)
2019-03-24 17:19 ` Jonathan Cameron [this message]
2019-03-24 17:22 ` Jonathan Cameron
2019-03-21 15:40 ` [PATCH v3 3/5] dt-bindings: iio: light: add vcnl4000 devicetree bindings Angus Ainslie (Purism)
2019-03-24 17:20 ` Jonathan Cameron
2019-03-28 17:53 ` Rob Herring
2019-03-21 15:40 ` [PATCH v3 4/5] iio: light: vcnl4000 add support for the VCNL4040 proximity and light sensor Angus Ainslie (Purism)
2019-03-24 17:24 ` Jonathan Cameron
2019-03-21 15:40 ` [PATCH v3 5/5] dt-bindings: iio: light: add vcnl4040 devicetree bindings Angus Ainslie (Purism)
2019-03-24 17:25 ` Jonathan Cameron
2019-03-28 17:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324171930.7580e6bb@archlinux \
--to=jic23@kernel.org \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tomas@novotny.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).