From: Jonathan Cameron <jic23@kernel.org>
To: Ruslan Babayev <ruslan@babayev.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
xe-linux-external@cisco.com, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check
Date: Sat, 11 May 2019 12:20:06 +0100 [thread overview]
Message-ID: <20190511122006.3e78486e@archlinux> (raw)
In-Reply-To: <20190505192438.2644-1-ruslan@babayev.com>
On Sun, 5 May 2019 12:24:36 -0700
Ruslan Babayev <ruslan@babayev.com> wrote:
> The driver doesn't actually rely on any DT properties. Removing this
> check makes it usable on ACPI based platforms.
>
> Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
> Cc: xe-linux-external@cisco.com
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ds4424.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> index 883a47562055..2b3ba1a66fe8 100644
> --- a/drivers/iio/dac/ds4424.c
> +++ b/drivers/iio/dac/ds4424.c
> @@ -236,12 +236,6 @@ static int ds4424_probe(struct i2c_client *client,
> indio_dev->dev.of_node = client->dev.of_node;
> indio_dev->dev.parent = &client->dev;
>
> - if (!client->dev.of_node) {
> - dev_err(&client->dev,
> - "Not found DT.\n");
> - return -ENODEV;
> - }
> -
> data->vcc_reg = devm_regulator_get(&client->dev, "vcc");
> if (IS_ERR(data->vcc_reg)) {
> dev_err(&client->dev,
prev parent reply other threads:[~2019-05-11 11:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 19:24 [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check Ruslan Babayev
2019-05-11 11:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190511122006.3e78486e@archlinux \
--to=jic23@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=ruslan@babayev.com \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).