From: Jonathan Cameron <jic23@kernel.org>
To: "João Seckler" <joaoseckler@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Stefan Popa <stefan.popa@analog.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: ad9832: Add device tree support
Date: Sun, 19 May 2019 12:19:35 +0100 [thread overview]
Message-ID: <20190519121935.341fd173@archlinux> (raw)
In-Reply-To: <20190518204825.4kh5qkqo2e5q2se6@smtp.gmail.com>
On Sat, 18 May 2019 17:48:25 -0300
João Seckler <joaoseckler@gmail.com> wrote:
> Add a of_device_id struct variable and subsequent call to
> MODULE_DEVICE_TABLE macro to support device tree.
>
> Signed-off-by: João Seckler <joaoseckler@gmail.com>
> Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
> Co-developed-by: Anderson Reis <andersonreisrosa@gmail.com>
> Signed-off-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
> Co-developed-by: Andre Tadeu de Carvalho <andre.tadeu.de.carvalho@gmail.com>
Hi All,
Missing the setting of the relevant entry in the spi_driver structure.
Otherwise looks fine,
Thanks,
Jonathan
> ---
> drivers/staging/iio/frequency/ad9832.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index 74308a2e72db..51e97c74c6b2 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -451,6 +451,13 @@ static int ad9832_remove(struct spi_device *spi)
> return 0;
> }
>
> +static const struct of_device_id ad9832_of_match[] = {
> + { .compatible = "adi,ad9832", },
> + { .compatible = "adi,ad9835", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, ad9832_of_match);
> +
> static const struct spi_device_id ad9832_id[] = {
> {"ad9832", 0},
> {"ad9835", 0},
next prev parent reply other threads:[~2019-05-19 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 20:48 [PATCH] staging: iio: ad9832: Add device tree support João Seckler
2019-05-19 11:19 ` Jonathan Cameron [this message]
2019-05-20 8:49 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190519121935.341fd173@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joaoseckler@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).