From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counter: ftm-quaddec: needs HAS_IOMEM
Date: Sat, 8 Jun 2019 14:31:11 +0100 [thread overview]
Message-ID: <20190608143111.6c481920@archlinux> (raw)
In-Reply-To: <20190601213805.32733-1-thomas@m3y3r.de>
On Sat, 1 Jun 2019 23:38:05 +0200
Thomas Meyer <thomas@m3y3r.de> wrote:
> the driver fails for UML with:
> drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap'
>
> Fix it by depending on HAS_IOMEM
Missing Signed-off-by.
Unfortunately I came across another patch for this before yours so
already have this fixed in the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/counter/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index 138ecd8a8fbd..6298344b536b 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -50,6 +50,7 @@ config STM32_LPTIMER_CNT
> module will be called stm32-lptimer-cnt.
>
> config FTM_QUADDEC
> + depends on HAS_IOMEM
> tristate "Flex Timer Module Quadrature decoder driver"
> help
> Select this option to enable the Flex Timer Quadrature decoder
prev parent reply other threads:[~2019-06-08 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 21:38 [PATCH] counter: ftm-quaddec: needs HAS_IOMEM Thomas Meyer
2019-06-08 13:31 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608143111.6c481920@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).