From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: linux-iio@vger.kernel.org,
Eugen Hristev <eugen.hristev@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Jonathan Cameron <jic23@kernel.org>,
Georg Ottinger <g.ottinger@abatec.at>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Boris Brezillon <boris.brezillon@collabora.com>
Subject: Re: [RFC] iio: adc: at91: fix acking DRDY irq (again)
Date: Wed, 12 Jun 2019 10:15:33 +0200 [thread overview]
Message-ID: <20190612081419.GM25472@piout.net> (raw)
In-Reply-To: <20190611115603.GA11086@lenoch>
On 11/06/2019 13:56:03+0200, Ladislav Michl wrote:
> Driver also contains some code for TC triggers. How is that supposed to
> work? [**] The very same manual states in chapter 39.5.5:
> "If one of the TIOA outputs is selected, the corresponding Timer Counter
> channel must be programmed in Waveform Mode."
> There are two drivers touching TC: drivers/clocksource/timer-atmel-tcb.c
> and drivers/pwm/pwm-atmel-tcb.c, they seem to conflict each other and
They don't, they can work simultaneously, on different TCBs. I'm still
planning to rework pwm-atmel-tcb to switch it to the proper binding.
> none of them is anyhow related to ADC driver. Here it would seem
> appropriate to have TC MFD driver and allocate timers for ADC, PWM and
> clocksource from there.
No, MFD is way too late for clocksource, this would break some platforms.
However, there is definitively some timer framework that is missing to
allow handling of timers that are not used as clocksource/clockevent
devices. So indeed, there is a missing piece to make the TC trigger
work.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-12 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 11:56 [RFC] iio: adc: at91: fix acking DRDY irq (again) Ladislav Michl
2019-06-12 8:15 ` Alexandre Belloni [this message]
2019-06-12 9:31 ` Ladislav Michl
2019-06-20 8:43 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612081419.GM25472@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@collabora.com \
--cc=eugen.hristev@microchip.com \
--cc=g.ottinger@abatec.at \
--cc=jic23@kernel.org \
--cc=ladis@linux-mips.org \
--cc=linux-iio@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=maxime.ripard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).