From: Jonathan Cameron <jic23@kernel.org>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: freeman.liu@spreadtrum.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/14] iio: adc: sc27xx: Replace devm_add_action() followed by failure action with devm_add_action_or_reset()
Date: Sun, 14 Jul 2019 15:51:57 +0100 [thread overview]
Message-ID: <20190714155157.7e4a37b0@archlinux> (raw)
In-Reply-To: <20190708123243.11713-1-huangfq.daxian@gmail.com>
On Mon, 8 Jul 2019 20:32:43 +0800
Fuqian Huang <huangfq.daxian@gmail.com> wrote:
> devm_add_action_or_reset() is introduced as a helper function which
> internally calls devm_add_action(). If devm_add_action() fails
> then it will execute the action mentioned and return the error code.
> This reduce source code size (avoid writing the action twice)
> and reduce the likelyhood of bugs.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/sc27xx_adc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c
> index ec86f640e963..d7ca002cbb17 100644
> --- a/drivers/iio/adc/sc27xx_adc.c
> +++ b/drivers/iio/adc/sc27xx_adc.c
> @@ -546,10 +546,9 @@ static int sc27xx_adc_probe(struct platform_device *pdev)
> return -ENXIO;
> }
>
> - ret = devm_add_action(dev, sc27xx_adc_free_hwlock,
> + ret = devm_add_action_or_reset(dev, sc27xx_adc_free_hwlock,
> sc27xx_data->hwlock);
> if (ret) {
> - sc27xx_adc_free_hwlock(sc27xx_data->hwlock);
> dev_err(dev, "failed to add hwspinlock action\n");
> return ret;
> }
> @@ -563,9 +562,8 @@ static int sc27xx_adc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = devm_add_action(dev, sc27xx_adc_disable, sc27xx_data);
> + ret = devm_add_action_or_reset(dev, sc27xx_adc_disable, sc27xx_data);
> if (ret) {
> - sc27xx_adc_disable(sc27xx_data);
> dev_err(dev, "failed to add ADC disable action\n");
> return ret;
> }
prev parent reply other threads:[~2019-07-14 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 12:32 [PATCH 02/14] iio: adc: sc27xx: Replace devm_add_action() followed by failure action with devm_add_action_or_reset() Fuqian Huang
2019-07-14 14:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714155157.7e4a37b0@archlinux \
--to=jic23@kernel.org \
--cc=freeman.liu@spreadtrum.com \
--cc=huangfq.daxian@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).