From: Jonathan Cameron <jic23@kernel.org>
To: "Bárbara Fernandes" <barbara.fernandes@usp.br>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
stefan.popa@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
kernel-usp@googlegroups.com, Wilson Sales <spoonm@spoonm.org>
Subject: Re: [PATCH v2] staging: iio: ad7192: create of_device_id array
Date: Sun, 14 Jul 2019 17:30:50 +0100 [thread overview]
Message-ID: <20190714173050.2b6306a0@archlinux> (raw)
In-Reply-To: <20190628194922.13277-1-barbara.fernandes@usp.br>
On Fri, 28 Jun 2019 16:49:22 -0300
Bárbara Fernandes <barbara.fernandes@usp.br> wrote:
> Create list of compatible device ids to be matched with those stated in
> the device tree.
>
> Signed-off-by: Bárbara Fernandes <barbara.fernandes@usp.br>
> Signed-off-by: Wilson Sales <spoonm@spoonm.org>
> Co-developed by: Wilson Sales <spoonm@spoonm.org>
> ---
Patch is fine and applied to the togreg branch of iio.git.
Only thing to note is that reviewers and maintainers often have
poor memories (or are jet lagged which is my excuse today!)
so it helps to put a change log here under the ---
Thanks,
Jonathan
> drivers/staging/iio/adc/ad7192.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 3d74da9d37e7..70118db98d94 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -810,11 +810,23 @@ static const struct spi_device_id ad7192_id[] = {
> {"ad7195", ID_AD7195},
> {}
> };
> +
> MODULE_DEVICE_TABLE(spi, ad7192_id);
>
> +static const struct of_device_id ad7192_of_match[] = {
> + { .compatible = "adi,ad7190" },
> + { .compatible = "adi,ad7192" },
> + { .compatible = "adi,ad7193" },
> + { .compatible = "adi,ad7195" },
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(of, ad7192_of_match);
> +
> static struct spi_driver ad7192_driver = {
> .driver = {
> .name = "ad7192",
> + .of_match_table = ad7192_of_match,
> },
> .probe = ad7192_probe,
> .remove = ad7192_remove,
prev parent reply other threads:[~2019-07-14 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 19:49 [PATCH v2] staging: iio: ad7192: create of_device_id array Bárbara Fernandes
2019-07-14 16:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714173050.2b6306a0@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=barbara.fernandes@usp.br \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=spoonm@spoonm.org \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).